Skip to content

Fixed compund SPDX expression resolution in detection & clue matches#619

Merged
OmkarPh merged 1 commit intodevelopfrom
fix/missing-license-expressions_spdx
Dec 9, 2023
Merged

Fixed compund SPDX expression resolution in detection & clue matches#619
OmkarPh merged 1 commit intodevelopfrom
fix/missing-license-expressions_spdx

Conversation

@OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Dec 6, 2023 •
edited
Loading

This fixes the spdx license expression resolution issue discussed in #610

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Dec 6, 2023 •
edited
Loading

Hey @AyanSinhaMahapatra
Can you share some scans with complex license expressions?
I just want to ensure there aren't any edge cases

@OmkarPh OmkarPh changed the title Fixed compund SPDX expression resolution in detection & clues matches Fixed compund SPDX expression resolution in detection & clue matches Dec 6, 2023
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @OmkarPh
The issue was resolved by this.
Here's another scan I used for testing a long license-expression:
test.json.txt

Looks good to me now, should be good. For match-level license-expressions this should be enough, there could be composite license-expression corner cases but no use building a perfect license-expression -> SPDX license expression here in workbench, as that's something that should be (and is presently) handled in SCTK.
Anyway I think we are soon having SPDX license expressions everywhere we have our expressions, so then this will be better as we don't want to do this computation on the workbench side.
Please merge!

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Dec 9, 2023 •
edited
Loading

Thanks @AyanSinhaMahapatra
Merging !

Looks good to me now, should be good. For match-level license-expressions this should be enough, there could be composite license-expression corner cases but no use building a perfect license-expression -> SPDX license expression here in workbench, as that's something that should be (and is presently) handled in SCTK. Anyway I think we are soon having SPDX license expressions everywhere we have our expressions, so then this will be better as we don't want to do this computation on the workbench side. Please merge!

That's nice 😄
This would still be useful in maintaining backward compatibility

@OmkarPh OmkarPh merged commit 99a1525 into develop Dec 9, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Dec 13, 2023
Closed
@pombredanne pombredanne deleted the fix/missing-license-expressions_spdx branch December 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OmkarPh @AyanSinhaMahapatra