Fix irregular scroll behavior for files in deeply nested FileTree#599
Merged
OmkarPh merged 2 commits intofeature/unittestsfrom Oct 2, 2023
Merged
Fix irregular scroll behavior for files in deeply nested FileTree#599OmkarPh merged 2 commits intofeature/unittestsfrom
OmkarPh merged 2 commits intofeature/unittestsfrom
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
AyanSinhaMahapatra
changed the base branch from
v4.0-react-typescript
to
feature/unittests
AyanSinhaMahapatra
approved these changes
Sep 25, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM! @OmkarPh
This is fixed now in this branch.
One thing is sometimes after clicking on the file, it takes a few seconds in the table view to load the resource, and was wondering if we can also show the Working icon here?
…etree render Signed-off-by: Omkar Phansopkar <[email protected]>
Collaborator
Author
|
Hey @AyanSinhaMahapatra |
AyanSinhaMahapatra
approved these changes
Oct 2, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks @OmkarPh for the quick fix, please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #590