Merged
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…to feature/unittests
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…to feature/unittests
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…ild errors Signed-off-by: Omkar Phansopkar <[email protected]>
…etree render Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Fix irregular scroll behavior for files in deeply nested FileTree
Close file option & cleanup before imports
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Fixed Empty directory being shown with file icon
…ble dimensions Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Automatic height for table
… outdated docs Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
AyanSinhaMahapatra
approved these changes
Oct 25, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM @OmkarPh, thanks!
Some minor things to note:
- Are https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-old and https://github.com/nexB/scancode-workbench/tree/feature/unittests/test-db used currently and if not should they not be removed entirely?
- The husky pre-commit increases the time to create commits, and usually we run only linters and other smaller/faster checks in pre-commits, and not the full test-suite? This time will increase when there are more comprehensive tests so this is something that should be considered.
But we can do these separately too, feel free to merge.
Update Documentation
Member
|
Merging! #591 (review) can be addressed at #556 |
Collaborator
Author
This, was fixed in other branch.
Ohk, lets discuss about this later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #601