add option to zoom in, out and reset#357
Merged
steven-esser merged 1 commit intoaboutcode-org:developfrom Mar 6, 2019
Merged
Conversation
Contributor
Author
|
why is the travis build failing in the last step? can someone help me figure it out? |
Contributor
|
@vsvipul I think that build failure may just be a fluke, I will restart the and see. |
Contributor
|
@vsvipul From what I can tell, I think the Travis CI errors are because the PR was opened from a fork. We can disregard the build failures for now I think. |
steven-esser
suggested changes
Mar 5, 2019
Contributor
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
The meat of the commit looks good. As a matter of convention, we at nexB sign all of our commits using git commit -s.
@vsvipul Can you please squash and recommit your changes with a signed git commit?
fixes aboutcode-org#356. Signed-off-by: vsvipul <[email protected]>
Contributor
Author
|
@MaJuRG i have made the required changes. Thanks. :) |
steven-esser
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #356.
Used
Ctrl + = for zoom in
Ctrl + - for zoom out
Ctrl + 0 for zoom reset