Detect plantuml license#4666
Merged
AyanSinhaMahapatra merged 6 commits intoaboutcode-org:developfrom Jan 9, 2026
Merged
Conversation
Signed-off-by: uttam282005 <[email protected]>
Signed-off-by: uttam282005 <[email protected]>
Signed-off-by: uttam282005 <[email protected]>
Signed-off-by: uttam282005 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds license detection support for PlantUML's multi-license structure, allowing users to choose from MIT, Apache-2.0, EPL-2.0, LGPL-3.0+, or GPL-3.0+.
- Added new license detection rule
plantuml_1.RULEto identify PlantUML's disjunctive license expression from their README - Added false positive rule to prevent incorrect GPL-2.0 detection from PlantUML's Javadoc badge URL
- Added test case to validate the detection rule
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/licensedcode/data/rules/plantuml_1.RULE |
New license detection rule for PlantUML's multi-license notice with disjunctive expression |
src/licensedcode/data/rules/false-positive-plantuml_1.RULE |
False positive rule to prevent GPL-2.0 detection from javadoc badge URL |
tests/licensedcode/data/datadriven/lic4/plantuml_license_notice.txt |
Test input file containing PlantUML's license notice from their README |
tests/licensedcode/data/datadriven/lic4/plantuml_license_notice.txt.yml |
Expected test output defining the disjunctive license expression |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: uttam282005 <[email protected]>
Signed-off-by: uttam282005 <[email protected]>
AyanSinhaMahapatra
approved these changes
Jan 9, 2026
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @uttam282005! LGTM
Merging!
AyanSinhaMahapatra
merged commit b2c4bd0
into
aboutcode-org:develop
32 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4579
Summary
This PR adds license detection support for PlantUML's unique multi-license structure, where users can choose from MIT, Apache-2.0, EPL-2.0, LGPL-3.0+, or GPL-3.0+.
Changes
plantuml_1.RULE: New license detection rule that identifies PlantUML's license notice from their README, capturing the full disjunctive license expression(mit OR apache-2.0 OR epl-2.0 OR lgpl-3.0-plus OR gpl-3.0-plus)false-positive-plantuml_1.RULE: False positive rule to prevent incorrect GPL-2. 0 detection from PlantUML's Javadoc badge URL that contains "gplv2" in the pathplantuml_license_notice.txtand corresponding.ymlfile to validate the detection ruleTesting
Included data-driven test case in
tests/licensedcode/data/datadriven/lic4/to ensure accurate detection of PlantUML's multi-license notice.Tasks
Run tests locally to check for errors.