packagedcode: don't use removed ast module attributes#4539
Merged
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom Oct 28, 2025
Merged
packagedcode: don't use removed ast module attributes#4539AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom
Conversation
This is needed for Python 3.14 compatibility. Signed-off-by: Maxwell G <[email protected]>
7 tasks
pombredanne
reviewed
Sep 10, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. Is the logic really the same?
src/packagedcode/build.py
Outdated
| if isinstance(statement_v, (ast.Str, ast.Constant)): | ||
| value = statement_v.s | ||
| value.append(e.value) | ||
| if isinstance(statement_v, ast.Constant) and isinstance(statement_v.value, str): |
Member
There was a problem hiding this comment.
The logic is now different, is it?
if isinstance(statement_v, (ast.Str, ast.Constant)): would kick in on either of ast.Str or ast.Constant but now it only kicks in with ast.Constant with a string value?
AyanSinhaMahapatra
approved these changes
Oct 28, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@gotmax23 LGTM!
Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for Python 3.14 compatibility.
Tasks
Run tests locally to check for errors.