packagedcode: replace unmaintained toml with tomllib/tomli#4532
packagedcode: replace unmaintained toml with tomllib/tomli#4532AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
toml has been unmaintained for years and was superseded by tomli on PyPI which was eventually added to the stdlib as tomllib in Python 3.11. Signed-off-by: Maxwell G <[email protected]>
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@gotmax23 Thanks++ for bringing this up and adding a PR.
Everything looks good to me, just one update required:
- Also update the requirements file similarly: https://github.com/aboutcode-org/scancode-toolkit/blob/develop/requirements.txt#L72, this is used for release archives and local development installations.
Is there a command to update them? Usually, they'd be be generated by |
|
I will link here the Fedora Change page that contains more info about deprecation of toml and availability of tomli in older systems https://fedoraproject.org/wiki/Changes/DeprecatePythonToml |
Updates setup-mini.cfg and various requirement files to use the intended version of tomli for various installation methods. Reference: #4532 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
merged commit a372ce2
into
aboutcode-org:develop
|
Thanks++ @gotmax23 @xsuchy , this is merged with some minor updates at #4594
You can run https://github.com/aboutcode-org/scancode-toolkit/blob/develop/etc/scripts/gen_requirements.py to update a requirements file (from a vritualenv, after doing a configure and Note that we also have to use https://github.com/aboutcode-org/scancode-toolkit/blob/develop/etc/scripts/fetch_thirdparty.py and update https://github.com/aboutcode-org/thirdparty-packages before we release so we have the wheels/sources and .ABOUT files used to create the release archive apps. |
3 participants
toml has been unmaintained for years and was superseded by tomli on PyPI which was eventually added to the stdlib as tomllib in Python 3.11.
Tasks
Run tests locally to check for errors.