fix: change version number in field "key" for code-credit-license-1.0-0#4416
Conversation
Signed-off-by: Leo Reinmann <[email protected]>
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @leoreinmann
Could you also chnage the license filename to fix the failing tests?
src/licensedcode/data/licenses/code-credit-license-1.0-0.LICENSE -> src/licensedcode/data/licenses/code-credit-license-1.0.0.LICENSE
Signed-off-by: Leo Reinmann <[email protected]>
|
@AyanSinhaMahapatra Yes, I've noticed it and changed it with the second commit 😄 |
|
Actually on further thought, we usually deprecate the license if the license key has a bug, and create a new license with the correct key and filename (with the same data verbatim) because:
@pombredanne what do you think? |
|
@AyanSinhaMahapatra and @pombredanne i think it's probably ok to update the license key in this case; it's a license that is very likely not used. |
|
@AyanSinhaMahapatra Are the failing tests related to the PR? |
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@leoreinmann no the test failures are related to #4369,
this is all good to merge now. Thanks++
AyanSinhaMahapatra
merged commit 0c7022e
into
aboutcode-org:develop
* fix: change version number in field "key" for code-credit-license-1.0-0 * fix: change file name for license "code-credit-license-1.0.0" Signed-off-by: Leo Reinmann <[email protected]> Signed-off-by: Alok Kumar <[email protected]>
3 participants
Fixes #4415
The key "code-credit-license-1.0-0" seems to be a typo because in the "short_name", the "name "and also the license text the version number is "1.0.0 ". The other licenses code-credit-license-1.0.1. and code-credit-license-1.1.0 have the semantic versioning pattern. Also on their website all their licenses use semantic versioning.
Tasks
Run tests locally to check for errors.