Improve license detection#4412
Merged
AyanSinhaMahapatra merged 9 commits intodevelopfrom Jun 13, 2025
Merged
Conversation
Reference: #3707 Reference: #3970 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-license-detection
branch
from
0283601 to
127bd49
Compare
6 tasks
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
* Do not include copyright statement in license detection * Handle cases of license/trademarks not being present correctly Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-license-detection
branch
from
3b7a1a5 to
3a97066
Compare
pombredanne
reviewed
Jun 11, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Some nits for your consideration!
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-license-detection
branch
from
76ae306 to
cfb9140
Compare
Member
Author
|
All green and feedback resolved, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add misc license detection, post-processing and
--todoimprovements.Fixes #3707 Follow references to license files in package-ecosystem specific places (beside package manifests)
Fixes #3969 Fix license references bug and refactor to avoid code duplication
Tasks
Run tests locally to check for errors.