Merged
Conversation
AyanSinhaMahapatra
requested changes
Apr 16, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@pombredanne thanks!
We need to add required phrases + skip_for_required_phrase_generation, or a high minimum coverage for these.
pombredanne
force-pushed
the
autosar-rules
branch
from
20bcbb7 to
6927ee9
Compare
Member
Author
I made these required phrases and fxied the DCO... but in all cases since these are only URLs they would come with a 100% minimum coverage for free:
|
pombredanne
force-pushed
the
autosar-rules
branch
from
6927ee9 to
94b5d7a
Compare
Member
Author
|
and I rebased. |
pombredanne
force-pushed
the
autosar-rules
branch
from
94b5d7a to
ae7ce23
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
autosar-rules
branch
from
ae7ce23 to
81a7de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new rules with URLs.
Fixes #3973
Tasks
Run tests locally to check for errors.