4181 update about to use license expression#4184
Conversation
…of 'dje_license' Signed-off-by: Chin Yeung Li <[email protected]>
Signed-off-by: Chin Yeung Li <[email protected]>
Signed-off-by: Chin Yeung Li <[email protected]>
…ap.min.css were switched. * Updated the ABOUT files to fix the error * Added package_url field Signed-off-by: Chin Yeung Li <[email protected]>
* Mainly added package_url into ABOUT files * Removed "package_url" field if it refers to borrowed code Signed-off-by: Chin Yeung Li <[email protected]>
Signed-off-by: Chin Yeung Li <[email protected]>
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @chinyeungli LGTM!
We should also have some linter/checker for ABOUT files to check for common issues and missing data, check if the referenced files are present etc. And add this to all repos via skeleton, we should probably open a seperate issue for this.
| @@ -5,4 +5,5 @@ copyright: Copyright (c) nexB Inc. and others. | |||
| homepage_url: https://www.aboutcode.org/ | |||
There was a problem hiding this comment.
Since we are doing a cleanup, we should probably delete this file, since this does not add any data to the package manifests already present here for scancode-toolkit.
There was a problem hiding this comment.
For the purpose of the ABOUT file, I think we still want to keep this file.
We can use the |
2 participants
Fixes #4181 - Update ABOUT files
Tasks
Run tests locally to check for errors.
This PR only consist of ABOUT files (i.e. no code changes), I believe the failing tests are as same as the current in the
developbranchSigned-off-by: Chin Yeung Li [email protected]