Bump commoncode to v32.2.0 and pin bs4#4149
Merged
AyanSinhaMahapatra merged 1 commit intodevelopfrom Mar 6, 2025
Merged
Conversation
AyanSinhaMahapatra
force-pushed
the
update-bs4-commoncode
branch
from
d4f73f9 to
6daeb21
Compare
There was an issue in copyright scan and other places which was caused by a breaking change in bs4, which is fixed in commoncode with https://github.com/aboutcode-org/commoncode/releases/tag/v32.2.0 Reference: #4129 Reference: aboutcode-org/commoncode#79 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
reviewed
Mar 6, 2025
| ('sha1', None), | ||
| ('md5', None), | ||
| ('sha256', None), | ||
| ('sha1', 0), |
Member
There was a problem hiding this comment.
That's a big change. What happened?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue in copyright scan and other places which was caused by a breaking change in bs4, which is fixed in commoncode with https://github.com/aboutcode-org/commoncode/releases/tag/v32.2.0
Reference: #4129
Reference: aboutcode-org/commoncode#79
Tasks
Run tests locally to check for errors.