Replace broken link for Sun Public License SPL 1.0#4109
Merged
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom Jun 25, 2025
Merged
Replace broken link for Sun Public License SPL 1.0#4109AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom
Conversation
alok1304
force-pushed
the
update_spl_url
branch
from
8e278bb to
1a0c0d9
Compare
AyanSinhaMahapatra
requested changes
Apr 5, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @alok1304, update_spl_url sounds like variable name, not a commit message title. Could you amend your commit to have a nice title? Similarly like you have in the PR. See also https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
Reference: aboutcode-org#3948 Signed-off-by: Alok Kumar <[email protected]>
alok1304
force-pushed
the
update_spl_url
branch
from
dc60bb7 to
0de498e
Compare
Member
|
Thanks++ @alok1304 Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3948
Replacing broken link for Sun Public License SPL 1.0 i.e change
https://opensource.org/licenses/SPL-1.0tohttps://opensource.org/license/sunpublic-php.Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar [email protected]