change default value of --process to (number of CPUs)-1#4104
change default value of --process to (number of CPUs)-1#4104AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
xsuchy
force-pushed
the
2980
branch
2 times, most recently
from
cc8c78b to
4ded913
Compare
|
I believe the tests failures on MacOS is not relevant to this code. |
There was a problem hiding this comment.
@xsuchy Thanks++ for the PR.
Overall this sounds like a nice idea, to increase the number of CPUs by default.
It seems like we have an agreement to have this at n-1 from #2980, and this sounds mostly fine to me, although n-2 could have been safer when users might have multiple other things open/in use if they are running scancode in their personal computers. But everywhere else this sounds great, and folks can always reduce the default CPU if it creates problems.
Not sure about the test failures, could you merge latest develop just to be sure?
@pombredanne please review this too.
Related: aboutcode-org#2980 Signed-off-by: Miroslav Suchý <[email protected]>
|
Rebased on top of develop branch. |
|
Thanks++ @xsuchy, this is a great addition! Merging. |
AyanSinhaMahapatra
merged commit 275d0df
into
aboutcode-org:develop
3 participants
Related: #2980
Tasks
Run tests locally to check for errors.
Test suite fails to run for me, but the script run correctly.