Fix failing --no-check-version cli option#4003
Merged
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom Dec 5, 2024
Merged
Fix failing --no-check-version cli option#4003AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
alexzurbonsen
force-pushed
the
fix-no-check-version-bug
branch
from
560ccb7 to
5470c3b
Compare
Currently, if the --no-check-version option is used, the scan fails because an unbound variable is passed to the run_scan function. Fix this by assigning None in that case. Add a test that passes with this change and fails without it. Signed-off-by: alexzurbonsen <[email protected]>
alexzurbonsen
force-pushed
the
fix-no-check-version-bug
branch
from
5470c3b to
706c0f7
Compare
AyanSinhaMahapatra
approved these changes
Dec 5, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM! Thanks @alexzurbonsen for reporting and fixing this!
It seems we missed this at #2662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the --no-check-version option is used, the scan fails because an unbound variable is passed to the
run_scanfunction.Fix by assigning
Nonein that case. Add a test that passes with this change and fails without it.Fixes #4004
Tasks
Run tests locally to check for errors.