Merged
Conversation
Signed-off-by: Jono Yang <[email protected]>
…ition #3971 Signed-off-by: Jono Yang <[email protected]>
JonoYang
requested review from
AyanSinhaMahapatra and
pombredanne
and removed request for
pombredanne
JonoYang
commented
Nov 6, 2024
| if TRACE: | ||
| raise | ||
|
|
||
| except Exception as e: |
Member
Author
There was a problem hiding this comment.
@AyanSinhaMahapatra @pombredanne I'm not sure if this is the best solution for #3971, I'd like to know if you guys have any better ideas.
AyanSinhaMahapatra
approved these changes
Nov 6, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks++ @JonoYang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates go-inspector to v0.5.0 . GoReSym is now built from source and has been updated to v3.0.1.