Merged
Conversation
Add a new matcher_order attribute to LicenseMatch and use it for sorting matches rather than the matcher string. This was we can ensure that there is a proper precedence between matchers when two matches are matching exactly the same text. The new sort order for matcher is like that: - 0: 1-hash - 1: 2-aho - 2: 1-spdx-id - 3: 3-seq - 4: 5-undetected - 5: 5-aho-frag - 6: 6-unknown The outcome is that a hash or aho match for the same text at the same position will take precedence of the SPDX id match, allowing to curate and correct some incorrect license expressions if needed. Reference: #3912 Reported-by: Ayan Sinha Mahapatra <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
And also improve other copyright detections Signed-off-by: Philippe Ombredanne <[email protected]>
Enable CREDITs detection in main authors loop And detect more copyrights Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
misc-copyrights2
branch
from
26a18ce to
665a71b
Compare
Member
|
The Azure CI is flaky and randomly fails with: This is an heisenbug only on Azure so I am going to merge anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Run tests locally to check for errors.