Update license rules and license detections#3905
Merged
pombredanne merged 11 commits intodevelopfrom Sep 26, 2024
Merged
Conversation
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
requested changes
Sep 6, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... IMHO you cam make the FPs smaller and fewers... And you should FP most if not all of the doc parts that are comments about licensing
...0-plus_and_gpl-2.0-plus_and_lgpl-2.0_and_lgpl-2.0-plus_and_lgpl-2.1_and_lgpl-2.1-plus_1.RULE
Outdated
Show resolved
Hide resolved
src/licensedcode/data/rules/linux-syscall-exception-gpl_11.RULE
Outdated
Show resolved
Hide resolved
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
3b8a9ce to
87da63f
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Added by @DennisClark Reference: #3908 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Add a new matcher_order attribute to LicenseMatch and use it for sorting matches rather than the matcher string. This was we can ensure that there is a proper precedence between matchers when two matches are matching exactly the same text. The new sort order for matcher is like that: - 0: 1-hash - 1: 2-aho - 2: 1-spdx-id - 3: 3-seq - 4: 5-undetected - 5: 5-aho-frag - 6: 6-unknown The outcome is that a hash or aho match for the same text at the same position will take precedence of the SPDX id match, allowing to curate and correct some incorrect license expressions if needed. Reference: #3912 Reported-by: Ayan Sinha Mahapatra <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
approved these changes
Sep 12, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Here are a few nits for your consideration. I often prefer a shorter false positive. Good to merge otherwise.
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #3922 Reported-by: Martin Ba @bilbothebaggins Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-license-rules
branch
from
d1b76a6 to
916bba5
Compare
Member
|
@AyanSinhaMahapatra Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Run tests locally to check for errors.