Add handler for packages.lock.json in nuget#3825
Merged
AyanSinhaMahapatra merged 12 commits intodevelopfrom Jun 26, 2024
Merged
Add handler for packages.lock.json in nuget#3825AyanSinhaMahapatra merged 12 commits intodevelopfrom
AyanSinhaMahapatra merged 12 commits intodevelopfrom
Conversation
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
AyanSinhaMahapatra
requested changes
Jun 25, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks++ @TG1999
See comments for a few questions and changes.
Also, typically we have lockfiles beside another package manifest right?
I was looking for examples of this and is this .csproj files for nuget? Are there other manifests which would be nice to parse and store?
Here is an example of a .csproj file and packages.lock.json together: https://github.com/ncblakely/GiantsTools/tree/main/Giants.Services to add as tests.
Should we not also do some lightweight package assembly here?
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Contributor
Author
|
Adressed all review comments, feel free to merge. |
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
approved these changes
Jun 26, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks++ @TG1999 merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: aboutcode-org/scancode.io#1263
Tasks
Run tests locally to check for errors.