Update to SPDX license list 3.24.0#3795
Merged
AyanSinhaMahapatra merged 6 commits intodevelopfrom Jun 10, 2024
Merged
Conversation
Reference: #3787 Reference: https://github.com/spdx/license-list-XML/releases/tag/v3.24.0 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3787 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3787 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-spdx-license-list-3.24
branch
from
e10c5f7 to
71563ba
Compare
Member
Author
|
@DennisClark this is ready for your initial review, see 31925f2 where we had also license detections info for license texts which were not exact matches. |
DennisClark
reviewed
Jun 5, 2024
src/licensedcode/data/licenses/asterisk-linking-protocols-exception.LICENSE
Show resolved
Hide resolved
DennisClark
reviewed
Jun 5, 2024
DennisClark
reviewed
Jun 5, 2024
DennisClark
reviewed
Jun 5, 2024
DennisClark
reviewed
Jun 5, 2024
DennisClark
reviewed
Jun 5, 2024
DennisClark
requested changes
Jun 5, 2024
Member
DennisClark
left a comment
DennisClark
left a comment
There was a problem hiding this comment.
@AyanSinhaMahapatra Please see my inline comments on some of the licenses with suggested changes; otherwise, everything else is approved.
AyanSinhaMahapatra
force-pushed
the
update-spdx-license-list-3.24
branch
from
8371608 to
e41de20
Compare
Member
Author
|
@DennisClark thanks! I've updated all the licenses accordingly from your feedback. |
pombredanne
requested changes
Jun 6, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! There are a few minor adjustments needed IMHO.
There are suggestions from @DennisClark and @pombredanne Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-spdx-license-list-3.24
branch
from
e41de20 to
61faf4a
Compare
Member
Author
|
@pombredanne Thanks for the feedback, I've resolved them all. Ready for review again! |
Member
|
we just need a changelog entry |
AyanSinhaMahapatra
force-pushed
the
update-spdx-license-list-3.24
branch
from
164cefc to
849ebea
Compare
Signed-off-by: Philippe Ombredanne <[email protected]> Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
These were added from @DennisClark Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-spdx-license-list-3.24
branch
from
849ebea to
efd5766
Compare
Member
Author
|
Thanks for your reviews and updates @pombredanne @DennisClark, now merging! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #3787
Reference: https://github.com/spdx/license-list-XML/releases/tag/v3.24.0
Tasks
Run tests locally to check for errors.