Resolve dependencies and improve JS support#3779
Merged
AyanSinhaMahapatra merged 14 commits intodevelopfrom Jun 19, 2024
Merged
Resolve dependencies and improve JS support#3779AyanSinhaMahapatra merged 14 commits intodevelopfrom
AyanSinhaMahapatra merged 14 commits intodevelopfrom
Conversation
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
27e5537 to
69bb143
Compare
Add parsers for pnpm-lock.yaml v5 and v6, and shrinkwrap.yaml specs with examples and package assembly. Reference: #3766 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
69bb143 to
ccf346a
Compare
Apply updates for all npm lockfiles. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
1869154 to
b9eb01d
Compare
Reference: #3780 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3102 Reference: #1514 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3746 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
b9eb01d to
f055ea7
Compare
Reference: #3746 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
2 times, most recently
from
02e83da to
3e11778
Compare
pombredanne
changed the title
pombredanne
requested changes
Jun 10, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... here are some first nits.
Adds is_direct attribute to differentiate between direct dependecy relationships and dependencies listed in lockfiles which have both direct and transitive dependencies together, which will have is_direct as False. Reference: #3780 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
3e11778 to
448fc36
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
2 times, most recently
from
74f402d to
82a51c0
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
82a51c0 to
b24b29f
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
requested changes
Jun 17, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Some final nits... then please merge!
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
improve-npm-support
branch
from
20420b2 to
f74a89b
Compare
Member
Author
|
@pombredanne Thanks for your comments, suggestions and improved texts for the attributes. I've added all of them, and now ready to merge. |
Fixes a bug where there was remaining double quotes on namespace and name for dependencies, which was effecting package resolution. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
reviewed
Jun 19, 2024
pombredanne
approved these changes
Jun 19, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Good to merge with just a minor nit wrt. a function name!
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Member
Author
|
All green, merging! Thanks @pombredanne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for resolving package dependencies with an initial focus on JavaScript npm packages as support by npm and yarn.
In particular:
Tasks
Run tests locally to check for errors.