Merged
Conversation
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Also use proper name for var: test_envt confuse test discovery Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Some tests never ran and the underlying needed some minor updates. Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #3667 Reported-by: Stefan @stefan6419846 Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
misc-updates
branch
from
606a3d0 to
6df90d5
Compare
pombredanne
commented
Feb 27, 2024
Member
Author
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
All green. @AyanSinhaMahapatra yours to review and merge
AyanSinhaMahapatra
approved these changes
Mar 15, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @pombredanne
Merging this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains miscellaneous small changes and fixes in tests, regex syntax and similar.
Thee are too small to be considered alone.
Tasks
Run tests locally to check for errors.