Fix-up an accidental use of SPDX's WITH operator in a rule#3628
Merged
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom Jan 5, 2024
fviernau:rules-fix-up-bsd-new-facebook-spdx-operator
Merged
Fix-up an accidental use of SPDX's WITH operator in a rule#3628AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom fviernau:rules-fix-up-bsd-new-facebook-spdx-operator
WITH operator in a rule#3628AyanSinhaMahapatra merged 2 commits intoaboutcode-org:developfrom
fviernau:rules-fix-up-bsd-new-facebook-spdx-operator
Conversation
The text denoted by the ID `facebook-patent-rights-2` actually contains a patent license, not a license exception. So, that ID must not be use as right-hand-side operand of the the `WITH` operation. Fix the issue by using `AND` instead of `WITH`. Signed-off-by: Frank Viernau <[email protected]>
The rule detects `bsd-new AND facebook-patent-rights-2`, not `bsd-new WITH facebook-patent-rights-2`. Signed-off-by: Frank Viernau <[email protected]>
AyanSinhaMahapatra
approved these changes
Jan 5, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @fviernau!
LGTM! Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust a rule to return
bsd-new AND facebook-patent-rights-2 OR gpl-2.0instead ofbsd-new WITH facebook-patent-rights-2 OR gpl-2.0.See individual commits.