Validate CLI inputs and paths #3596#3609
Merged
AyanSinhaMahapatra merged 2 commits intodevelopfrom Mar 18, 2024
Merged
Conversation
This is to ensure that the input are regular files or directories and that the output are writable files if they pre-exist. This is a fix for closely related issues: Referenced-by: #3588 Referenced-by: #3589 Referenced-by: #3590 Referenced-by: #3591 Referenced-by: #3592 Referenced-by: #3593 Referenced-by: #3594 Referenced-by: #3595 Referenced-by: #3596 Reported-by: Armijn Hemel @armijnhemel Reported-by: Till Jaeger @LeChasseur Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
commented
Mar 18, 2024
Member
Author
There was a problem hiding this comment.
Looking good. Merge ready. @AyanSinhaMahapatra Thanks for fixing the test
AyanSinhaMahapatra
approved these changes
Mar 18, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM! Thanks @pombredanne
Merging!
Collaborator
|
This one probably also fixes #3420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to ensure that the input are regular files or directories and that the output are writable files if they pre-exist.
This is a fix for closely related issues:
Referenced-by: #3588
Referenced-by: #3589
Referenced-by: #3590
Referenced-by: #3591
Referenced-by: #3592
Referenced-by: #3593
Referenced-by: #3594
Referenced-by: #3595
Referenced-by: #3596
Reported-by: Armijn Hemel @armijnhemel
Reported-by: Till Jaeger @LeChasseur
Fixes #0000
Tasks
Run tests locally to check for errors.