Add "--no-check-version" CLI option to scancode#2662
Merged
pombredanne merged 1 commit intoaboutcode-org:developfrom Aug 24, 2021
Merged
Add "--no-check-version" CLI option to scancode#2662pombredanne merged 1 commit intoaboutcode-org:developfrom
pombredanne merged 1 commit intoaboutcode-org:developfrom
Conversation
yns88
force-pushed
the
no-check-version
branch
3 times, most recently
from
2b87de9 to
ab57d6f
Compare
pombredanne
approved these changes
Aug 24, 2021
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM. Thank you ++ for this. This makes 100% sense.
This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely. Signed-off-by: Yunus Rahbar <[email protected]>
yns88
force-pushed
the
no-check-version
branch
from
ab57d6f to
23c8ef0
Compare
Member
|
All green! 💚 Thanks! merging. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely.
Tasks
Run tests locally to check for errors.