You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9a8128b
Browse filesBrowse the repository at this point in the historyBrowse files
committed
Merge origin/main into eva/js-to-rust-perf-pack
The pack branch was behind `origin/main`, and main had changed two files the
pack also touches (`desktop/src-tauri/src/lib.rs`,
`desktop/src/testing/e2eBridge.ts`). The pre-push branch-skew guard blocks
exactly this: local gates run on a tree CI will never build, so a green local
run can coexist with a red CI.
Textually clean, no conflicts. Because a clean merge is precisely where two
edits to one file can silently recombine, both directions were checked by
content rather than by conflict count: all 342 lines the pack added to those two
files are present in the merged tree, and all 17 lines main added are present
too. Nothing was reverted on either side.
Gated on the merged tree, which is what CI actually builds: `cargo test --lib`
2544 passed / 0 failed, `pnpm test` 4956 passed / 0 failed.
Co-authored-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz>
Co-authored-by: Tyler Longwell <[email protected]>
Signed-off-by: Tyler Longwell <[email protected]>
Desktop E2E: `cd desktop && pnpm test:e2e:smoke` for mock-bridge smoke
240
+
coverage, or `pnpm test:e2e:integration` for relay-backed coverage. These
241
+
scripts build the required E2E bridge before running Playwright.
239
242
240
243
See [TESTING.md](TESTING.md) for the full multi-agent E2E guide.
241
244
@@ -446,11 +449,10 @@ description. See [PR #803](https://github.com/block/buzz/pull/803).
446
449
447
450
1.**Kind `39000` for channel metadata, not `41`** — kind 41 is NIP-01 (unused). All kinds defined in `buzz-core/src/kind.rs`.
448
451
2.**Relay queries must specify `kinds`** — omitting `kinds` triggers the p-gate (403). Always include explicit kind filters.
449
-
3.**`messages search`must include `--kinds`** — an open-ended search (no kinds) hits the relay p-gate and returns 403. Pass at least `--kinds 9,45001,45003` to scope the query.
452
+
3.**`messages search`chooses its own supported kinds** — do not add a `--kinds` option; the current command does not accept one. This differs from raw relay filters, which still need explicit kinds.
450
453
4.**Worktrees: `cd` in the same command** — shell CWD doesn't persist between tool calls. Use `cd /path && cargo build` as one command.
451
454
5.**Desktop crate excluded from root workspace** — `cargo test` at repo root does NOT run desktop tests. Use `cargo test --manifest-path desktop/src-tauri/Cargo.toml` explicitly.
452
-
6.**Desktop Tauri fmt fails in worktrees and blocks commits** — the pre-commit hook runs `just desktop-tauri-fmt`, which fails in git worktrees because `cargo fmt` resolves workspace paths relative to the worktree root. Run `just desktop-tauri-fmt` from the main checkout to apply the fix, then re-stage and commit. CI is unaffected.
453
-
7.**React render perf: `React.memo` is all-or-nothing** — it only skips a re-render when *every* prop is reference-stable; one unstable prop (inline arrow/JSX, or a hook returning a fresh `{}`/`[]`/`Map` each render) defeats it. Two repeat offenders: (a) React Query results (`useMutation`/`useQuery`) are a **new object each render** — depend on the stable method (`mutation.mutateAsync`), not the object; (b) derived `Map`/array state that recomputes on a version bump — wrap in a content-equality ref cache (`shared/hooks/useStableReference.ts`). When chasing interaction lag, **measure with DevTools closed and no perf probes** (an open Web Inspector + per-keystroke `console.log` inflate the numbers), and isolate by removing one suspect at a time rather than guessing.
455
+
6.**React render perf: `React.memo` is all-or-nothing** — it only skips a re-render when *every* prop is reference-stable; one unstable prop (inline arrow/JSX, or a hook returning a fresh `{}`/`[]`/`Map` each render) defeats it. Two repeat offenders: (a) React Query results (`useMutation`/`useQuery`) are a **new object each render** — depend on the stable method (`mutation.mutateAsync`), not the object; (b) derived `Map`/array state that recomputes on a version bump — wrap in a content-equality ref cache (`shared/hooks/useStableReference.ts`). When chasing interaction lag, **measure with DevTools closed and no perf probes** (an open Web Inspector + per-keystroke `console.log` inflate the numbers), and isolate by removing one suspect at a time rather than guessing.
454
456
455
457
---
456
458
@@ -511,27 +513,12 @@ class instances, cached promises) survive across remounts. Every community-scope
511
513
singleton needs a reset function wired into `resetCommunityState()` in
Copy file name to clipboardExpand all lines: SECURITY.md
+1-3Lines changed: 1 addition & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -121,6 +121,4 @@ We use `cargo audit` in CI to scan for known vulnerabilities in dependencies.
121
121
## Disclosure Policy
122
122
123
123
We follow [coordinated disclosure](https://en.wikipedia.org/wiki/Coordinated_vulnerability_disclosure).
124
-
Once a fix is ready and released, we will publish a security advisory on
125
-
GitHub describing the vulnerability, its impact, and the fix. Reporters will
126
-
be credited unless they request anonymity.
124
+
Reporters will be credited unless they request anonymity.
0 commit comments