Skip to content

Improved the Norwegian translations - #169

Merged
abh merged 8 commits into
abh:masterfrom
DandelionSprout:master
Sep 7, 2019
Merged

Improved the Norwegian translations#169
abh merged 8 commits into
abh:masterfrom
DandelionSprout:master

Conversation

@DandelionSprout

@DandelionSprout DandelionSprout commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

In particular, I added some strings that were missing from nb.po, in the hopes of alleviating the fact that the Norwegian Bokmål translation is not actually being used on https://www.ntppool.org at the time of writing, thus ensuring that whoever knows how to make that translation go live can do that.

@DandelionSprout

DandelionSprout commented Jun 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Having now done nb.po, join.html, configuration.html, and intro.html for the Bokmål translation, are there any more files that are mandatory to translate in order for the Bokmål translation to go live? There's a few more files in https://github.com/abh/ntppool/tree/master/docs/ntppool/en, but they seem to be pretty convoluted and rarely used, so I was hoping to skip those that weren't considered crucial.

@abh
abh merged commit ec69ec1 into abh:master Sep 7, 2019
abh added a commit that referenced this pull request Sep 7, 2019
@abh
Add Norsk Bokmål to beta site
f5ced93 
#169
@abh

abh commented Sep 7, 2019

Copy link
Copy Markdown
Owner

This should show up on https://web.beta.grundclock.com/en/ in a little bit when the containers have rebuilt, etc. Will you let me know if it looks okay so I can enable it for the production site?

@DandelionSprout

DandelionSprout commented Sep 7, 2019

Copy link
Copy Markdown
Contributor Author

It seems to be showing up pretty well there.

Upon inspection of the on-site implementation of my translation, I notice ~6 minor grammar errors that I most likely want to correct, and I hope to have enough time to do so in a few hours' time.

@DandelionSprout DandelionSprout mentioned this pull request Sep 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DandelionSprout @abh