Repository navigation
Commit b5b5e97
committed
fix(install): zero umask at startup so ancestor dirs are created at exact 0755
GNU install calls umask(0) early in main() so that ancestor directories
created by -D/-d always get exactly DEFAULT_MODE (0755) regardless of the
caller's umask. Our implementation passed DEFAULT_MODE to mkdirat /
fs::create_dir_all without zeroing umask first, so restrictive umasks
(e.g. 0027, 0077, 0111) produced wrong ancestor modes.
Changes:
- Add zero_umask() to uucore::mode using the existing rustix dependency
- Call it at the top of install's uumain (unix only)
- Fix the -d code path to use DirBuilder::mode(DEFAULT_MODE) instead of
fs::create_dir_all, which defaults to 0777 and would create 0777
ancestors with umask now zeroed
- Replace the broken probe-based assertions in two tests with direct
assert_eq!(0o40_755) checks, matching the GNU-guaranteed value
Fixes uutils#12714
Related: uutils#11363, uutils#127131 parent 0c16403 commit b5b5e97
3 files changed
Lines changed: 47 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
189 | 196 | | |
190 | 197 | | |
191 | 198 | | |
| |||
515 | 522 | | |
516 | 523 | | |
517 | 524 | | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
523 | 545 | | |
524 | 546 | | |
525 | 547 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
205 | 217 | | |
206 | 218 | | |
207 | 219 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | 108 | | |
113 | 109 | | |
114 | 110 | | |
| |||
118 | 114 | | |
119 | 115 | | |
120 | 116 | | |
121 | | - | |
122 | | - | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
123 | 121 | | |
124 | 122 | | |
125 | 123 | | |
| |||
134 | 132 | | |
135 | 133 | | |
136 | 134 | | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | 135 | | |
142 | 136 | | |
143 | 137 | | |
| |||
149 | 143 | | |
150 | 144 | | |
151 | 145 | | |
152 | | - | |
153 | | - | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
154 | 150 | | |
155 | 151 | | |
156 | 152 | | |
| |||
0 commit comments