Add support for using the modularized passagemath distributions#274
Add support for using the modularized passagemath distributions#274rparini merged 13 commits intoabelfunctions:masterfrom
Conversation
rparini
left a comment
There was a problem hiding this comment.
Thanks for contributing this. I had not heard of passagemath before but I definitely like the idea of being able to run without the full sage environment.
This is sort of two PRs: one adding doctests and one changing the imports for passagemath. I don't mind keeping them together but if you just want to get the passagemath support in quickly you might like to move the docstring stuff to another PR.
|
Thanks a lot for your comments. I'm reworking it so that the tox tests run your pytest-based testing facility (which I had somehow overlooked when I prepared this PR.) |
|
By the way, the ruff linter fails also in the master branch - see https://github.com/abelfunctions/abelfunctions/actions/runs/12719866991/job/35460723682 |
Yeah ruff updated, I'll address that |
|
The latest version of ruff is now supported in master |
7d3865f to
e82342e
Compare
|
On this branch, ruff on github actions complains Can't reproduce locally (with same version of ruff, 0.9.2). Any ideas? |
|
Not sure what the issue was but running locally in the repository root I get so I've committed that result. Hopefully passes now |
0743900 to
98fe1be
Compare
2929791 to
5066fef
Compare
Co-authored-by: Robert Parini <[email protected]>
|
Rebased on top of the current master, ready for review/merging. The package works as well with passagemath as it does with recent versions of Sage: Errors with Singular remain, as discussed in #270. |
|
Thanks @mkoeppe, I don't want to merge this in with the tests failing but looking at PyPi it seems like passagemath versions only go back as far as sage 10.4? The last version of sage that the tests worked on was 10.1 so I'd ideally like to require passagemath <= 10.1 for now until #270 is fixed but doesn't look possible. |
|
The oldest passsagemath is version 10.4; I started this fork only in October 2024, in response to the collapse of governance in the Sage project. |
rparini
left a comment
There was a problem hiding this comment.
I've got later versions of Sagemath working on main so this is good to go now
|
Wonderful! |
No description provided.