Skip to content

Comments

Add support for using the modularized passagemath distributions#274

Merged
rparini merged 13 commits intoabelfunctions:masterfrom
passagemath:passagemath
Sep 5, 2025
Merged

Add support for using the modularized passagemath distributions#274
rparini merged 13 commits intoabelfunctions:masterfrom
passagemath:passagemath

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 2, 2025

No description provided.

Copy link
Member

@rparini rparini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this. I had not heard of passagemath before but I definitely like the idea of being able to run without the full sage environment.

This is sort of two PRs: one adding doctests and one changing the imports for passagemath. I don't mind keeping them together but if you just want to get the passagemath support in quickly you might like to move the docstring stuff to another PR.

@mkoeppe mkoeppe marked this pull request as draft January 12, 2025 20:26
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 12, 2025

Thanks a lot for your comments. I'm reworking it so that the tox tests run your pytest-based testing facility (which I had somehow overlooked when I prepared this PR.)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 12, 2025

@rparini
Copy link
Member

rparini commented Jan 17, 2025

By the way, the ruff linter fails also in the master branch - see https://github.com/abelfunctions/abelfunctions/actions/runs/12719866991/job/35460723682

Yeah ruff updated, I'll address that

@rparini
Copy link
Member

rparini commented Jan 19, 2025

The latest version of ruff is now supported in master

@mkoeppe mkoeppe force-pushed the passagemath branch 2 times, most recently from 7d3865f to e82342e Compare January 19, 2025 19:25
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 19, 2025

On this branch, ruff on github actions complains

Run ruff check --output-format=github
Would reformat: setup.py
1 file would be reformatted, 41 files already formatted

Can't reproduce locally (with same version of ruff, 0.9.2). Any ideas?

@rparini
Copy link
Member

rparini commented Mar 2, 2025

Not sure what the issue was but running locally in the repository root I get

>>> ruff format
1 file reformatted, 41 files left unchanged
>>> ruff -V
ruff 0.9.2

so I've committed that result. Hopefully passes now

@mkoeppe mkoeppe force-pushed the passagemath branch 5 times, most recently from 0743900 to 98fe1be Compare April 2, 2025 06:25
@mkoeppe mkoeppe force-pushed the passagemath branch 2 times, most recently from 2929791 to 5066fef Compare July 24, 2025 18:27
This was referenced Jul 24, 2025
@mkoeppe mkoeppe marked this pull request as ready for review July 25, 2025 18:04
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2025

Rebased on top of the current master, ready for review/merging.

The package works as well with passagemath as it does with recent versions of Sage: Errors with Singular remain, as discussed in #270.

@mkoeppe mkoeppe requested a review from rparini July 25, 2025 18:07
@rparini
Copy link
Member

rparini commented Aug 27, 2025

Thanks @mkoeppe, I don't want to merge this in with the tests failing but looking at PyPi it seems like passagemath versions only go back as far as sage 10.4? The last version of sage that the tests worked on was 10.1 so I'd ideally like to require passagemath <= 10.1 for now until #270 is fixed but doesn't look possible.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 27, 2025

The oldest passsagemath is version 10.4; I started this fork only in October 2024, in response to the collapse of governance in the Sage project.

@rparini rparini mentioned this pull request Sep 5, 2025
Copy link
Member

@rparini rparini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got later versions of Sagemath working on main so this is good to go now

@rparini rparini merged commit 0d8a4d5 into abelfunctions:master Sep 5, 2025
15 checks passed
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 5, 2025

Wonderful!

@mkoeppe mkoeppe deleted the passagemath branch September 5, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants