Warnings as errors and compiler error cleanup#976
Merged
Conversation
This was referenced Aug 5, 2025
This was referenced Sep 17, 2025
This was referenced Dec 29, 2025
This was referenced Apr 23, 2026
This was referenced Apr 30, 2026
This was referenced May 12, 2026
This was referenced May 21, 2026
This was referenced May 22, 2026
This was referenced Jun 24, 2026
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configures warnings as errors
Runs formatting checks on release build (difference between formatting check enabled and disabled is about 40 seconds on my laptop)
Fixes all formatting issues
I opted to only run the formatting checks during the release build due to the significant increase in time to build.
Fixes #968