Skip to content

Enable .NET analyzers #928

Merged
EdwardCooke merged 1 commit into
aaubry:masterfrom
lahma:analyzers
Sep 2, 2024
Merged

Enable .NET analyzers #928
EdwardCooke merged 1 commit into
aaubry:masterfrom
lahma:analyzers

Conversation

@lahma

@lahma lahma commented Jun 4, 2024

Copy link
Copy Markdown
Contributor
  • enabled for main project, added exclusion for things that would make changes bigger
  • fix where makes sense
  • added couple polyfills that allow using better APIs on newer TFMs

Currently everything else is just a warning and allows gradually fix things when wanted in smaller PRs.

@lahma
lahma force-pushed the analyzers branch 3 times, most recently from bc7a448 to 95554d5 Compare June 16, 2024 16:43
@lahma
lahma force-pushed the analyzers branch 3 times, most recently from c1e2d59 to cda1bbd Compare July 14, 2024 19:01
@lahma
lahma force-pushed the analyzers branch 2 times, most recently from cdfd520 to 0d3f4e2 Compare September 1, 2024 17:01
@EdwardCooke

Copy link
Copy Markdown
Collaborator

Well want to get rid of the compiler warnings before merging this in. Other than that it looks good. I’ll get it in once those are fixed so it goes out in the next release.

@lahma

lahma commented Sep 2, 2024

Copy link
Copy Markdown
Contributor Author

Added the missing nameof usage, no warnings in build output.

@EdwardCooke
EdwardCooke merged commit 06b67d9 into aaubry:master Sep 2, 2024
@lahma
lahma deleted the analyzers branch September 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants