Repository navigation
Commit c060ebf
Fixes astropy#11407: Makes two additional fixes to the test SAMPWebClient:
* Its server loop (for accepting calls from the Hub) should block
until the client has actually registered with the hub (rather than
busy waiting)
* More importantly, there needs to be a lock associated with whether
or not the client is registered. The lock does not need to be
held by SAMPWebClient.register because the _server_thread blocks
until the _registered_event is set. However, SAMPWebClient.unregister
does need to hold the lock to ensure it does not unregister the client
when it is about to perform a pullCallbacks request to the hub.1 parent 22b28a2 commit c060ebf
1 file changed
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
| 155 | + | |
| 156 | + | |
155 | 157 | | |
156 | 158 | | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
160 | 162 | | |
| 163 | + | |
| 164 | + | |
161 | 165 | | |
162 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
163 | 171 | | |
164 | 172 | | |
165 | 173 | | |
| |||
205 | 213 | | |
206 | 214 | | |
207 | 215 | | |
| 216 | + | |
| 217 | + | |
208 | 218 | | |
209 | 219 | | |
210 | 220 | | |
211 | 221 | | |
212 | 222 | | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
213 | 230 | | |
214 | 231 | | |
215 | 232 | | |
| |||
0 commit comments