Skip to content

fix(ci): stop overlapping README refreshes cancelling publication - #31

Merged
aaronedev merged 3 commits into
mainfrom
fix/readme-refresh-cancellation
Nov 12, 2026
Merged

aaronedev merged 3 commits into
mainfrom
fix/readme-refresh-cancellation

Conversation

@aaronedev

@aaronedev aaronedev commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Why

The reported refresh successfully generated the README and organization cards, then was cancelled before its push. A scheduled refresh arrived while it was running. Both use readme-update, which previously cancelled the active run.

That left the committed “Awaiting authenticated refresh” cards in place despite a successful authenticated collection.

Change

Set cancel-in-progress: false so a scheduled or manual refresh waits for the active publisher to finish. Keep the shared concurrency group, so only one refresh publishes at a time. Bound the update job to 30 minutes so a stuck publisher releases the queue. A workflow regression test covers both settings.

Validation

  • GitHub Actions Python tests: 112 passed on e8d1dcb.
  • Serialized refresh runs and a 30-minute job timeout are covered by a workflow contract test.
  • Cubic's P2 timeout finding was addressed and its review thread was resolved.
  • The pre-existing scheduled refresh completed and published both statistics SVGs to main.
  • The workflow's cancellation and timeout behavior in production is verified only after this PR is merged and a later overlapping run occurs.

@codeant-ai

codeant-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #8ac2f Reviewed your PR 506957d Nov 12, 2026 · 16:48 16:51

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ❌ Failed 2026-11-12T16:48:27.634076Z
We couldn’t complete this review. Comment @codex security review to try again.
506957d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/readme.yaml Resolved
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The change appears safe to merge and protects the active README publisher from overlapping refreshes.

Summary

Changes cancel-in-progress to false so overlapping README refreshes no longer cancel the active publisher.

  • README refreshes let the active run publish before another run takes over.

Reviews (1) · Last reviewed commit: "fix(ci): let README refreshes finish bef..." · Reviewed by Greptile

@aaronedev
aaronedev merged commit 249bd90 into main Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant