Skip to content

fix(providers): set strict:false on chat-completions tools - #12272

Merged
michaelneale merged 1 commit into
aaif-goose:mainfrom
gokay-ai:cursor/openrouter-strict-false-2c55
Sep 22, 2026
Merged

michaelneale merged 1 commit into
aaif-goose:mainfrom
gokay-ai:cursor/openrouter-strict-false-2c55

Conversation

@gokay-ai

@gokay-ai gokay-ai commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #12247

Summary

Chat-completions format_tools now sets strict: false on each tool, matching the Responses API guard. Some OpenRouter upstreams apply strict tool calling when the flag is absent, which fills optional properties and breaks delegate.

Testing

cargo test -p goose-provider-types --lib formats::openai — 184 passed, including test_format_tools.

Related Issues

Fixes #12247

Some OpenRouter upstreams apply strict tool calling when the flag is
absent, filling optional properties and breaking tools like delegate.
Match the Responses API guard by emitting strict: false on each tool.

Fixes aaif-goose#12247

Signed-off-by: GokayAI <[email protected]>
@gokay-ai
gokay-ai requested a review from a team as a code owner September 21, 2026 10:34
Copilot AI lite review requested due to automatic review settings September 21, 2026 10:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@michaelneale

Copy link
Copy Markdown
Collaborator

checked with shadow PR and live tests, and this seems consistent with responses api too, tahnks.

@michaelneale
michaelneale added this pull request to the merge queue Sep 22, 2026
Merged via the queue into aaif-goose:main with commit d785bf7 Sep 22, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(openrouter): set strict: false on tools — strict-defaulting upstreams (GPT-5.6 via OpenRouter) fill every optional property and break delegate

3 participants