Skip to content
This repository was archived by the owner on Oct 10, 2026. It is now read-only.

Commit 020179c

Browse files
fix(web): use message-square icon for settled icon-less project threads in sidebar v2 (pingdotgg#4279)
1 parent 571a8b4 commit 020179c

2 files changed

Lines changed: 27 additions & 5 deletions

File tree

‎apps/web/src/components/ProjectFavicon.tsx‎

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { EnvironmentId } from "@t3tools/contracts";
22
import { isProjectFaviconFallbackUrl } from "@t3tools/shared/projectFavicon";
33
import { FolderIcon } from "lucide-react";
4+
import type { ComponentType } from "react";
45
import { useState } from "react";
56
import { useAssetUrl } from "../assets/assetUrls";
67

@@ -10,37 +11,56 @@ export function ProjectFavicon(input: {
1011
environmentId: EnvironmentId;
1112
cwd: string;
1213
className?: string | undefined;
14+
fallbackIcon?: ComponentType<{ className?: string }>;
1315
}) {
1416
const src = useAssetUrl(input.environmentId, {
1517
_tag: "project-favicon",
1618
cwd: input.cwd,
1719
});
20+
const FallbackIcon = input.fallbackIcon ?? FolderIcon;
1821

1922
if (!src || isProjectFaviconFallbackUrl(src)) {
20-
return <ProjectFaviconFallback className={input.className} />;
23+
return <ProjectFaviconFallback className={input.className} icon={FallbackIcon} />;
2124
}
2225

23-
return <ProjectFaviconImage key={src} src={src} className={input.className} />;
26+
return (
27+
<ProjectFaviconImage
28+
key={src}
29+
src={src}
30+
className={input.className}
31+
fallbackIcon={FallbackIcon}
32+
/>
33+
);
2434
}
2535

26-
function ProjectFaviconFallback({ className }: { readonly className?: string | undefined }) {
27-
return <FolderIcon className={`size-3.5 shrink-0 text-muted-foreground/50 ${className ?? ""}`} />;
36+
function ProjectFaviconFallback({
37+
className,
38+
icon: Icon,
39+
}: {
40+
readonly className?: string | undefined;
41+
readonly icon: ComponentType<{ className?: string }>;
42+
}) {
43+
return <Icon className={`size-3.5 shrink-0 text-muted-foreground/50 ${className ?? ""}`} />;
2844
}
2945

3046
function ProjectFaviconImage({
3147
src,
3248
className,
49+
fallbackIcon: FallbackIcon,
3350
}: {
3451
readonly src: string;
3552
readonly className?: string | undefined;
53+
readonly fallbackIcon: ComponentType<{ className?: string }>;
3654
}) {
3755
const [status, setStatus] = useState<"loading" | "loaded" | "error">(() =>
3856
loadedProjectFaviconSrcs.has(src) ? "loaded" : "loading",
3957
);
4058

4159
return (
4260
<>
43-
{status !== "loaded" ? <ProjectFaviconFallback className={className} /> : null}
61+
{status !== "loaded" ? (
62+
<ProjectFaviconFallback className={className} icon={FallbackIcon} />
63+
) : null}
4464
<img
4565
src={src}
4666
alt=""

‎apps/web/src/components/SidebarV2.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
CircleDashedIcon,
1515
CloudIcon,
1616
FolderPlusIcon,
17+
MessageSquareIcon,
1718
PlusIcon,
1819
SearchIcon,
1920
SquarePenIcon,
@@ -426,6 +427,7 @@ const SidebarV2Row = memo(function SidebarV2Row(props: {
426427
environmentId={thread.environmentId}
427428
cwd={props.projectCwd ?? ""}
428429
className="size-3.5"
430+
fallbackIcon={MessageSquareIcon}
429431
/>
430432
</span>
431433
{title}

0 commit comments

Comments
 (0)