Add some operations to the Math node.#111
Merged
aachman98 merged 2 commits intoaachman98:masterfrom Mar 7, 2020
Merged
Conversation
aachman98
approved these changes
Mar 6, 2020
Owner
aachman98
left a comment
aachman98
left a comment
There was a problem hiding this comment.
Hi, Sorry for the late reply. I had been busy for the last couple of months.
The code looks fine. Will be merging this by tomorrow (already approved), so if you want to make the change I've mentioned, feel free.
And thanks for contributing to Sorcar!
nodes/utilities/ScMathsOp.py
Outdated
| elif (op == 'FRACT'): | ||
| out["Value"] = x - math.floor(x) | ||
| elif (op == 'MOD'): | ||
| out["Value"] = int(x) % int(y) |
Owner
There was a problem hiding this comment.
no need to convert x & y to int
| ("SUB", "X - Y", "Subtraction"), | ||
| ("MULT", "X * Y", "Multiplication"), | ||
| ("DIV", "X / Y", "Division"), | ||
| None, |
Owner
There was a problem hiding this comment.
Thanks for this..
I didn't know you could use "None" to create a separator in the menu xD
Author
|
Thanks for your reply and review! |
aachman98
approved these changes
Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest adding some missing operations to the Math node: "sqrt", "abs", "min", "max", "round", "floor", "ceil", "fraction".
These are found in the Math node of Blender Shader and Composite, but not in Sorcar. I think it would be better if Sorcar's Math node could be used as well as that of Shader. Beginners from Shader node will be able to use without hesitation.
I understand that these operations can be achieved by combining existing nodes. But they will make some node trees simpler and more straightforward.
What do you think?