pkg: Add author and change SX127x prefix#6
Closed
jia200x wants to merge 40 commits intoaabadie:pkg_semtech-loramacfrom
Closed
pkg: Add author and change SX127x prefix#6jia200x wants to merge 40 commits intoaabadie:pkg_semtech-loramacfrom
jia200x wants to merge 40 commits intoaabadie:pkg_semtech-loramacfrom
Conversation
Owner
|
Please rework the PR, you are confusing me |
Owner
|
Better commenting in the initial PR where Francisco credit is missing, I'll add him |
Author
|
yes, sorry. Thought it was easier here. |
Owner
|
Thanks for reviewing btw @jia200x ! |
aabadie
pushed a commit
that referenced
this pull request
Jun 13, 2021
Consider the following configuration:
nib prefix
2001:16b8:4569:88fc::/62 dev #7 expires 7081 sec deprecates 3481 sec
2001:16b8:4569:88fe::/63 dev #6
If `_on_link()` stops at the first match, a packet received from #7 with a
destination in the downstream subnet in #6 would always be sent back via #7
if this happens to be the first entry in the list.
Instead, consider all prefixes and return the one that is the closest match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Alex,
I'm pushing 2 commits to your branch:
Cheers