Repository navigation
fix(a2ui_flutter): adopt a2ui_core's renderer renames - #3223
Merged
Merged
Conversation
#3194 renamed A2uiClientAction and A2uiClientError to A2uiRendererAction and A2uiRendererError, MessageProcessor.groupModel to model and getClientDataModel to getRendererDataModel, and replaced EventSource.addListener with subscribe. The adapter's tests and README still used the old names, so the package's tests no longer compiled on main.⚠️ Agent-generated
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the a2ui_flutter package to align with API changes, renaming groupModel to model, updating client-related types to renderer-related types, and migrating event listeners from addListener/removeListener to a subscription-based model (subscribe/unsubscribe). A review comment points out that the syntax ?processor.getRendererDataModel() in the README is invalid Dart syntax and suggests using a collection if instead.
#3205 standardized LICENSE files on http://www.apache.org/licenses/ and made the license check enforce it. a2ui_flutter's LICENSE, added in #3084, used https, so the static-checks job fails on main.⚠️ Agent-generated
andrewkolos
marked this pull request as ready for review
October 14, 2026 22:38
gspencergoog
approved these changes
Oct 14, 2026
nan-yu
approved these changes
Oct 14, 2026
Collaborator
|
Merge this PR now to address the license check failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#3194 renamed several
a2ui_coreAPIs after #3084's last CI run, so--after I merged #3084--a2ui_flutter's tests no longer compile on main. This PR updates the adapter's tests and README sample to the new names:A2uiClientActionandA2uiClientErrortoA2uiRendererActionandA2uiRendererErrorMessageProcessor.groupModeltoMessageProcessor.modelgetClientDataModeltogetRendererDataModelEventSource.addListenerandremoveListenertosubscribeandSubscription.unsubscribePre-launch Checklist
One time:
For this PR:
I have updated the relevant CHANGELOG.md file.If my branch is on a fork, I have verified that scripts/e2e_test.sh passes.If you need help, consider asking for advice on the discussion board.