Skip to content

fix: handle blank push notification config id consistently across transports #1012

Open

Description

@malladinagarjuna2

GetTaskPushNotificationConfigParams rejects a null id but permits an
empty string, and the two transports diverge on that input:

  • GrpcTransport sends .setId("").
  • RestTransport treats it as absent and requests the trailing-slash
    "default config" URL.

Identical caller code against the same ClientTransport method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.

Also corrects the Javadoc on GetTaskPushNotificationConfigParams, which
described id as optional and documented @throws for taskId or tenant
when the constructor actually validates taskId and id.

Activity

  1. prachisinghal-1 commented on Oct 23, 2026

    @prachisinghal-1
    Contributor

    Hi! I'm a second-year B.Tech CSE student and would like to make my first contribution to this project. I noticed that blank push notification config IDs are handled differently by the REST and gRPC transports. Is this issue still available to work on? I'd like to investigate the behavior, implement a fix, and add tests. Thank you!

  2. kabir commented on Oct 23, 2026

    @kabir
    Collaborator

    @prachisinghal-1 hi, yes please go ahead. Note we did something in #1092 which touches on this, so make sure to take this into account :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions