You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: handle blank push notification config id consistently across transports #1012
GetTaskPushNotificationConfigParams rejects a null id but permits an
empty string, and the two transports diverge on that input:
GrpcTransport sends .setId("").
RestTransport treats it as absent and requests the trailing-slash
"default config" URL.
Identical caller code against the same ClientTransport method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.
Also corrects the Javadoc on GetTaskPushNotificationConfigParams, which
described id as optional and documented @throws for taskId or tenant
when the constructor actually validates taskId and id.
Hi! I'm a second-year B.Tech CSE student and would like to make my first contribution to this project. I noticed that blank push notification config IDs are handled differently by the REST and gRPC transports. Is this issue still available to work on? I'd like to investigate the behavior, implement a fix, and add tests. Thank you!
Activity
prachisinghal-1 commentedon Oct 23, 2026
Hi! I'm a second-year B.Tech CSE student and would like to make my first contribution to this project. I noticed that blank push notification config IDs are handled differently by the REST and gRPC transports. Is this issue still available to work on? I'd like to investigate the behavior, implement a fix, and add tests. Thank you!
kabir commentedon Oct 23, 2026
@prachisinghal-1 hi, yes please go ahead. Note we did something in #1092 which touches on this, so make sure to take this into account :-)