Repository navigation
Isolate retrieved memories from system prompts - #305
Merged
ianmacartney merged 1 commit intoAug 26, 2026
Merged
Conversation
Contributor
Author
|
@ianmacartney when you have a moment, I’d appreciate a review. This keeps retrieved memory out of the system role, adds instruction-shaped regression coverage, and passes all 53 tests plus the production build. |
markavale
pushed a commit
to markavale/ai-town
that referenced
this pull request
Oct 9, 2026
…ed-memories Isolate retrieved memories from system prompts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This narrows the trust boundary without claiming that prompt injection can be eliminated: model identity and behavior stay in the system role, while recalled content is demoted to data and cannot change the chat-message structure.
Verification
npm test -- --runInBand— 53 tests passednpm run build— passednpx prettier --check convex/agent/conversation.ts convex/agent/conversation.test.ts— passed after formattingnpm run lint— blocked on current upstreammain: ESLint 8 rejects the ESM.eslintrc.jsexport withUnexpected top-level property "__esModule"Closes #300