Merged
Conversation
Tested on morpho blue, 24.8% faster:
before: check_fee(bytes4,address) (paths: 38, time: 21.82s (paths: 21.82s, models: 0.00s), bounds: [])
after: check_fee(bytes4,address) (paths: 39, time: 16.41s (paths: 16.41s, models: 0.00s), bounds: [])
Avoids duplicating work:
- load pgm[pc] to know the current instruction (doing a chunk lookup + indexing in the code bytevec)
- load pgm[pc+1:pc+1+operand_size] for PUSHn instructions (every time it is executed, which can be expensive)
- load pgm[pc] again to know the next_pc
Instead we do this eagerly once and then remember the result.
Contributor
Author
|
Tested on Farcaster, 11% faster: |
(avoids stack too deep error with solc 0.8.26) a16z/cicada#8
daejunpark
reviewed
May 22, 2024
daejunpark
approved these changes
May 23, 2024
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Jun 18, 2025
### 🕓 Changelog This commit updates the version `pragma`s in all 🐍Vyper source files to target the latest `master` version `0.4.3rc2`, aligning with the release of Vyper's newest release candidate version [`0.4.3rc1`](https://github.com/vyperlang/vyper/releases/tag/v0.4.3rc1). Furthermore, all 🐍 snekmate contracts now target the new 🐍Vyper [default EVM version](vyperlang/vyper#4633) `prague`. Also, we now target the `prague` EVM version for all `halmos`-based tests, as the previously missing opcodes `MCOPY`, `TLOAD`, and `TSTORE` have been added via [a16z/halmos#293](a16z/halmos#293) and [a16z/halmos#463](a16z/halmos#463). Eventually, all submodules have been updated to their most recent commits. --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
willbrown84
added a commit
to willbrown84/snekmate
that referenced
this pull request
Sep 23, 2025
### 🕓 Changelog This commit updates the version `pragma`s in all 🐍Vyper source files to target the latest `master` version `0.4.3rc2`, aligning with the release of Vyper's newest release candidate version [`0.4.3rc1`](https://github.com/vyperlang/vyper/releases/tag/v0.4.3rc1). Furthermore, all 🐍 snekmate contracts now target the new 🐍Vyper [default EVM version](vyperlang/vyper#4633) `prague`. Also, we now target the `prague` EVM version for all `halmos`-based tests, as the previously missing opcodes `MCOPY`, `TLOAD`, and `TSTORE` have been added via [a16z/halmos#293](a16z/halmos#293) and [a16z/halmos#463](a16z/halmos#463). Eventually, all submodules have been updated to their most recent commits. --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
void-rider5560p
added a commit
to void-rider5560p/snekmate
that referenced
this pull request
Sep 28, 2025
### 🕓 Changelog This commit updates the version `pragma`s in all 🐍Vyper source files to target the latest `master` version `0.4.3rc2`, aligning with the release of Vyper's newest release candidate version [`0.4.3rc1`](https://github.com/vyperlang/vyper/releases/tag/v0.4.3rc1). Furthermore, all 🐍 snekmate contracts now target the new 🐍Vyper [default EVM version](vyperlang/vyper#4633) `prague`. Also, we now target the `prague` EVM version for all `halmos`-based tests, as the previously missing opcodes `MCOPY`, `TLOAD`, and `TSTORE` have been added via [a16z/halmos#293](a16z/halmos#293) and [a16z/halmos#463](a16z/halmos#463). Eventually, all submodules have been updated to their most recent commits. --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely driven by flamegraphs, I kept squeezing until the fetch-decode-execute loop almost disappeared from flamegraphs (now dominated by other things like calls to
resolve_address_alias):Tested on morpho blue, 24.8% faster:
Avoids duplicating work:
Instead we do this eagerly once and then remember the result.
Plus some extra goodies: