commitAuthors:bugfix - fix when pass invalid line to SetCommitAuthors#978
Merged
Conversation
iancardosozup
requested review from
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
February 9, 2022 14:16
matheusalcantarazup
suggested changes
Feb 9, 2022
iancardosozup
force-pushed
the
bugfix/commit-authors
branch
from
February 9, 2022 14:53
1c0f78f to
1ead9f2
Compare
iancardosozup
force-pushed
the
bugfix/commit-authors
branch
from
February 9, 2022 16:53
1ead9f2 to
90dfac3
Compare
matheusalcantarazup
suggested changes
Feb 9, 2022
iancardosozup
force-pushed
the
bugfix/commit-authors
branch
from
February 10, 2022 16:10
90dfac3 to
aa85cc8
Compare
wiliansilvazup
added
kind/bug
iancardosozup
force-pushed
the
bugfix/commit-authors
branch
2 times, most recently
from
February 10, 2022 17:37
e147108 to
6e0972a
Compare
matheusalcantarazup
suggested changes
Feb 10, 2022
… and changed formatters error handling approach Fix a bug in internal/utils/file.go where line value wasn't being restored to 0 when loop restarted, instead of ignoring erros and adding vulnerabilities to analysis slices now we ignore vulnerabilities we can't parse and add an error log to final analysis. Also added error return to GetDependencyCodeFilepathAndLine and GetDependencyInfo and some logging messages when this error is found. Removed unused function ReplacePathSeparator. Also changed some LogError to LogErrorWithLevel and setting errors to analysisError to be print on analysis end. Signed-off-by: Ian Cardoso <[email protected]>
iancardosozup
force-pushed
the
bugfix/commit-authors
branch
from
February 10, 2022 18:18
6e0972a to
a8b6450
Compare
Contributor
|
I will approve this pull request, but I believe that in the near future it will be necessary to improve this formatter structure.There is a lot of duplicated code, I believe we could have something similar to the default formatter of the engine, leaving only the parse of the output for each tool, I also don't see much sense in the separation between the engines and formatters package, just complicating the project structure. |
nathanmartinszup
approved these changes
Feb 10, 2022
nathanmartinszup
requested review from
matheusalcantarazup and
nathanmartinszup
February 10, 2022 19:11
nathanmartinszup
approved these changes
Feb 10, 2022
matheusalcantarazup
approved these changes
Feb 10, 2022
Contributor
This is definitely true. I've already thought about some possible improvements to this, I think we should discuss it. |
nathanmartinszup
pushed a commit
that referenced
this pull request
Feb 10, 2022
… and changed formatters error handling approach (#978) Fix a bug in internal/utils/file.go where line value wasn't being restored to 0 when loop restarted, instead of ignoring erros and adding vulnerabilities to analysis slices now we ignore vulnerabilities we can't parse and add an error log to final analysis. Also added error return to GetDependencyCodeFilepathAndLine and GetDependencyInfo and some logging messages when this error is found. Removed unused function ReplacePathSeparator. Also changed some LogError to LogErrorWithLevel and setting errors to analysisError to be print on analysis end. Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 0c1e691)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in internal/utils/file.go where line value wasn't being restored to 0 when loop restarted, adding error return to GetDependencyCodeFilepathAndLine and GetDependencyInfo and some logging messages when this error is found. Removed unused function ReplacePathSeparator. Also changed some LogError to LogErrorWithLevel and setting errors to analysisError to be print on analysis end
Signed-off-by: Ian Cardoso [email protected]
- What I did
- How to verify it
- Description for the changelog