bundler:chore - improve tests and code cleaning#925
Merged
Conversation
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
January 14, 2022 16:36
matheusalcantarazup
force-pushed
the
bundler-improvements
branch
from
January 14, 2022 16:50
cc057c3 to
4d279b1
Compare
This commit add some new asserts on successful parsing bundler results to verify that all fields of Vulnerability was filled. Some code organization was also made, and the entities and enum packages was removed and the bundler schema output was moved to bundler package. This commit also fix a bug when parsing invalid output from Bundler. The `strings.Split(output, "Name:")` on `parseOutput` return a list with one element when the split fails, so when Bundler return an output that is not expected we still try to parse this invalid output which results invalid vulnerabilities. To fix this a validation was added before the split to check if output contains the `Name:` field. Updates #718 Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
bundler-improvements
branch
from
January 14, 2022 17:43
4d279b1 to
652ead2
Compare
nathanmartinszup
approved these changes
Jan 14, 2022
iancardosozup
approved these changes
Jan 14, 2022
wiliansilvazup
approved these changes
Jan 19, 2022
This was referenced Jan 20, 2022
matheusalcantarazup
added a commit
that referenced
this pull request
Jan 21, 2022
This commit add some new asserts on successful parsing bundler results to verify that all fields of Vulnerability was filled. Some code organization was also made, and the entities and enum packages was removed and the bundler schema output was moved to bundler package. This commit also fix a bug when parsing invalid output from Bundler. The `strings.Split(output, "Name:")` on `parseOutput` return a list with one element when the split fails, so when Bundler return an output that is not expected we still try to parse this invalid output which results invalid vulnerabilities. To fix this a validation was added before the split to check if output contains the `Name:` field. Updates #718 Signed-off-by: Matheus Alcantara <[email protected]> (cherry picked from commit 112e82e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add some new asserts on successful parsing bundler results
to verify that all fields of Vulnerability was filled.
Some code organization was also made, and the entities and enum packages
was removed and the bundler schema output was moved to bundler package.
This commit also fix a bug when parsing invalid output from Bundler.
The
strings.Split(output, "Name:")onparseOutputreturn a list withone element when the split fails, so when Bundler return an output that
is not expected we still try to parse this invalid output which results
invalid vulnerabilities. To fix this a validation was added before the
split to check if output contains the
Name:field.Updates #718
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog