brakeman:fix - search for Gemfile's before start analysis #877
Merged
Conversation
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
December 15, 2021 19:38
matheusalcantarazup
marked this pull request as draft
December 15, 2021 19:39
Contributor
Author
|
Still in draft until #878 is merged, since some code improvements was made there. |
matheusalcantarazup
changed the title
matheusalcantarazup
force-pushed
the
brakeman-search-for-gemfile
branch
4 times, most recently
from
December 16, 2021 13:39
0adf5d5 to
99e6a7f
Compare
If there was no `Gemfile` file in the current directory, Brakeman would generate an error stating that the project to be analyzed was not a Ruby on Rails project. This commit fix this issue by looking for a directory path that contains a `Gemfile` filename and them using this path as a work dir to execute Brakeman. Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
brakeman-search-for-gemfile
branch
from
December 17, 2021 16:18
99e6a7f to
f65205c
Compare
matheusalcantarazup
marked this pull request as ready for review
December 17, 2021 16:18
nathanmartinszup
approved these changes
Dec 20, 2021
lucasbrunozup
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there was no
Gemfilefile in the current directory, Brakeman wouldgenerate an error stating that the project to be analyzed was not a Ruby
on Rails project.
This commit fix this issue by looking for a directory path that contains
a
Gemfilefilename and them using this path as a work dir to executeBrakeman.
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog