formatters/ruby:chore - removing unnecessary error messages#1024
Merged
Conversation
nathanmartinszup
force-pushed
the
chore/bundler-brakeman-warnings
branch
from
March 10, 2022 14:27
deb3ce5 to
be3f158
Compare
Previously if the project had ruby between programming languages but is not a ruby on rails project or does not have a Gemfile.lock an error would be reported for each scenario. This pull request changes these error messages introduced in commits cd839ef and 9245d7d to be considered just warnings, as there is no need to point them out as errors, since it is only intended to inform the user. Signed-off-by: Nathan Martins <[email protected]>
nathanmartinszup
force-pushed
the
chore/bundler-brakeman-warnings
branch
from
March 10, 2022 14:31
be3f158 to
b6a1cf5
Compare
nathanmartinszup
marked this pull request as ready for review
March 10, 2022 14:40
nathanmartinszup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup,
oliveirafelipezup and
wiliansilvazup
as code owners
March 10, 2022 14:40
iancardosozup
approved these changes
Mar 10, 2022
matheusalcantarazup
approved these changes
Mar 10, 2022
matheusalcantarazup
pushed a commit
that referenced
this pull request
Mar 10, 2022
Previously if the project had ruby between programming languages but is not a ruby on rails project or does not have a Gemfile.lock an error would be reported for each scenario. This pull request changes these error messages introduced in commits cd839ef and 9245d7d to be considered just warnings, as there is no need to point them out as errors, since it is only intended to inform the user. Signed-off-by: Nathan Martins <[email protected]> (cherry picked from commit 358fd4a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the project had ruby between programming languages but is
not a ruby on rails project or does not have a Gemfile.lock an error
would be reported for each scenario.
This pull request changes these error messages introduced in commits
cd839ef and 9245d7d to be considered just warnings, as there is no
need to point them out as errors, since it is only intended to
inform the user.
Signed-off-by: Nathan Martins [email protected]
- What I did
- How to verify it
- Description for the changelog