lint:chore - Fix lint, format and Horusec API tests#1004
Merged
Conversation
wiliansilvazup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
nathanmartinszup
as code owners
February 22, 2022 21:59
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
from
February 22, 2022 22:08
92df006 to
eb7d138
Compare
wiliansilvazup
marked this pull request as draft
February 22, 2022 22:15
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
5 times, most recently
from
February 22, 2022 23:01
ce72c79 to
92b2e0c
Compare
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
from
February 22, 2022 23:48
92b2e0c to
2bb3818
Compare
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
from
February 23, 2022 15:59
2bb3818 to
4f048fd
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
wiliansilvazup
marked this pull request as ready for review
February 23, 2022 16:00
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
from
February 24, 2022 11:40
4f048fd to
878333c
Compare
nathanmartinszup
approved these changes
Feb 24, 2022
matheusalcantarazup
approved these changes
Feb 24, 2022
Contributor
|
The commit message should be updated to inform that we remove the test and not just commented. |
Look in this commit I removed the test in `horus_api_test.go`, because in local machine this works fine, but in github actions don't work. Signed-off-by: Wilian Gabriel <[email protected]>
wiliansilvazup
force-pushed
the
chore/fix-pipeline
branch
from
February 24, 2022 15:26
878333c to
be39768
Compare
iancardosozup
approved these changes
Feb 24, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Apr 4, 2022
Look in this commit I removed the test in `horus_api_test.go`, because in local machine this works fine, but in github actions don't work. Signed-off-by: Wilian Gabriel <[email protected]> (cherry picked from commit d7fcbe3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look in this commit I commented the test in
horus_api_test.go,because in local machine this works fine, but in github actions don't
and I don't know what us can do.
Signed-off-by: Wilian Gabriel [email protected]