Skip to content

[Chore] Run webview CI tests with four workers (#2288) - #2308

Merged
edelauna merged 1 commit into
mainfrom
feature/webview-ci-four-workers-1t4ocrxz9ojmv
Nov 6, 2026
Merged

[Chore] Run webview CI tests with four workers (#2288)#2308
edelauna merged 1 commit into
mainfrom
feature/webview-ci-four-workers-1t4ocrxz9ojmv

Conversation

@zoomote2

@zoomote2 zoomote2 Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Closes: #2288

Description

The webview CI Vitest run now uses four workers on hosted runners. The previous budget was one worker. The change is one line in webview-ui/vitest.config.ts: maxWorkers: isCI ? 4 : undefined (was isCI ? 1 : undefined). The setting applies only when CI=true, so it covers the measured Ubuntu and Windows hosted runner classes. Local (non-CI) runs stay unchanged.

Forks, isolation, assertions, coverage, onConsoleLog handling, and CI test timeouts are unchanged. The default forks pool stays in place. No benchmark harness is included in this PR. Vitest stays at 4.1.12. No errors are suppressed.

Benchmark

From #2288 (GitHub-hosted benchmark, commit 86197abe, Node 22.23.4 / Vitest 4.1.12, two repetitions per setting, 174 files / 2,269 tests, no retries):

Test configuration 1 worker median 4 workers median
Ubuntu with coverage 283s 95s
Windows without coverage 246s 105s

Local Linux spot-check for this PR (18 vCPU, CI=true): the src/components subset (147 files / 1,799 tests) took 235.8s with --max-workers=1 and 108.9s with the new four-worker config.

Once CI runs on this PR, compare test-step duration, job duration, runner minutes, and time until required checks turn green against main. Two repetitions do not establish reliability or p95.

Rollback

Revert the worker budget to one worker. Change maxWorkers: isCI ? 4 : undefined back to maxWorkers: isCI ? 1 : undefined in webview-ui/vitest.config.ts, or revert this commit. No other cleanup is required.

Test Procedure

  • CI=true pnpm turbo run test:coverage --filter=@roo-code/vscode-webview: 181 files / 2,333 tests passed, 133.1s (full inventory with coverage, four workers, Linux).
  • Same src/components subset with --max-workers=1 vs the new config: 235.8s vs 108.9s.
  • pnpm --filter @roo-code/vscode-webview lint: pass.
  • pnpm --filter @roo-code/vscode-webview check-types: pass.
  • pnpm exec prettier --check webview-ui/vitest.config.ts: pass.
  • Root pnpm test: pass on rerun (14/14 Turbo tasks). One earlier run had two failures in src/__tests__/extension.spec.ts under heavy parallel load. That file passes 24/24 in isolation. The failures are unrelated to this change.
  • Reviewers: watch the platform-unit-test jobs of the Code QA workflow on this PR.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I reviewed my own code with care.
  • Writing Style: The PR title and description use Simplified Technical English (ASD-STE100): short sentences, plain words, active voice, one idea per sentence, no contractions.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable). (N/A: config-only change. The existing inventory proves the contract.)
  • Test Helpers (test changes only): (N/A: no test changes.)
  • Visual Snapshot (UI changes only): (N/A: no UI change.)
  • Documentation Impact: I checked if my changes need documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable. This change does not alter rendered UI.

Videos (interaction / animation only)

Not applicable.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Additional Notes

Issue #2288 notes a rare Ubuntu teardown error, Closing rpc while "onUserConsoleLog" was pending, seen once in twelve benchmark repetitions. The upstream fix ships in Vitest 5.1.0-beta.1. This repo uses Vitest 4.1.12. That issue is tracked separately and is not addressed here.

Get in Touch

0x7777777_

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1

  • coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zoomote2

zoomote2 Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

No code issues found. See session

Reviewed 64d59c9

@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review November 6, 2026 01:14
@github-actions github-actions Bot added the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Nov 6, 2026
@edelauna
edelauna added this pull request to the merge queue Nov 6, 2026
@github-actions github-actions Bot removed the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Nov 6, 2026
Merged via the queue into main with commit 7ec58d4 Nov 6, 2026
38 checks passed
@edelauna
edelauna deleted the feature/webview-ci-four-workers-1t4ocrxz9ojmv branch November 6, 2026 02:02
easonLiangWorldedtech added a commit to easonLiangWorldedtech/Zoo-Code that referenced this pull request Nov 7, 2026
@easonLiangWorldedtech
Merge upstream main 73931fe into vps2/f5-api-wiring
0f5cfcc 
Upstream moved e943530 to 73931fe, 9 commits: Zoo-Code-Org#2275 zustand v5.0.16, Zoo-Code-Org#2274 ai sdk bump, Zoo-Code-Org#2273 @types/katex, Zoo-Code-Org#2341 the v3.96.0 release prep, Zoo-Code-Org#2309 batch 3 of the no-explicit-any suppression removal in the integrations area, Zoo-Code-Org#2297 the interrupted-message-write resume fix, Zoo-Code-Org#2120 partial-message throttling, Zoo-Code-Org#2308 webview tests on four workers, and Zoo-Code-Org#1838 reporting emergency condense like the automatic path. No campaign head is an ancestor of that main, so this is a merge commit rather than a fast-forward.

The single conflict was the src/extension/api.ts import block. It is resolved as a union: main adds TaskMessagesReadError, getErrorCode and tracePersistenceEvent, and this branch keeps its import type { Task } line. Neither side was dropped.

Suppression baseline: Zoo-Code-Org#2309 lowered the no-explicit-any counts in the integrations area, so the never-raise-a-count baseline is mains lower tree at 73931fe, not the e943530 one. The pre-commit hook shells out to pnpm, which is not installed on this lane PATH, so this merge commit was made with --no-verify and the gates - tsc, eslint with the suppressions file, prettier and the vitest lanes for every file in the diff - are run on the merged tree instead.
@easonLiangWorldedtech easonLiangWorldedtech mentioned this pull request Nov 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edelauna edelauna edelauna approved these changes
@taltas taltas Awaiting requested review from taltas taltas is a code owner
@JamesRobert20 JamesRobert20 Awaiting requested review from JamesRobert20 JamesRobert20 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: run webview tests with four workers

2 participants

@edelauna @roomote