[Improve] Reduce chat memory retained during long sessions by zoomote2[bot] · Pull Request #2217 · Zoo-Code-Org/Zoo-Code

zoomote2 · 2026-10-28T03:28:39Z

Created by Roomote. View the session.

Copy of #1466 (original author account was deleted). Original work by @taltas — see the original PR for prior discussion and review comments.

What changed

Intern repeated strings in completed chat messages and task history. Bound each cache to 10,000 entries and 2,000,000 retained characters with FIFO eviction.
Skip partial messages and stale updates. Rebind equal strings in unchanged flat messages across state pushes while retaining the incoming message objects; messages with newly deserialized object or array fields still take the normal interning path.
Clear the message cache when the active task changes or is cleared, including when JSON serialization omits an undefined task ID. Rebuild the history cache when history is replaced.
Preserve task identity on stale pushes and on pushes without messages.
Keep cache writes outside React state updaters. Preserve chat and row instances across task changes and message completion.
Add focused coverage for cache routing, lifecycle, sequence boundaries, message-mirror synchronization, eviction limits, and row-instance preservation.

Why

State broadcasts repeatedly deserialize message and history strings. Sharing equal strings reduces retained allocations within a transcript and across successive snapshots. The cache limits bound its own retention; clearing a cache does not guarantee that other UI references release the same messages.

Heap measurements

Measured in real VS Code 1.100.0 under Xvfb using CDP forced GC on the Zoo Code webview renderer. Each workload loads a deterministic saved transcript of 602 UI messages, including 300 command/output pairs with 16.4–16.9 KiB outputs, then switches to a small task. A full-state refresh after hydration exercises sharing across broadcasts.

Three fresh measurement sessions per workload and variant produced 12 successful samples. The extension host, dependencies and styles are held constant; both webview builds use production minification without source maps. External downloads are blocked during the workload, and seed tasks use a local mock model.

Median loaded renderer heap:

Workload	Base	Candidate	Reduction
32 distinct outputs repeated across 300 commands	41.42 MiB	31.75 MiB	9.67 MiB (23%)
300 unique outputs	41.58 MiB	36.63 MiB	4.95 MiB (12%)

Base webview modules: 97228c7ca9b032e5fe466e57e24fe72fbf405192. Candidate: b9a6ba03cb93c0f92f06cfb00c82ae7d488db7cb.

These are historical measurements of the recorded revisions and have not been rerun for the review fixes. Repeated outputs benefit from cache interning; unchanged strings are also shared across snapshots after FIFO eviction, which helps the unique workload. The comparison does not isolate each mechanism’s contribution.

These replace the earlier standalone synthetic 8.6 MiB estimate. The new measurements exercise the real extension/webview path with generated saved-task data; they are not an organic user session and do not measure CPU overhead, image-rich messages, continuously streamed execution, extension-host heap, or process RSS.

Task-switch finding

All six candidate post-switch snapshots contain zero old output strings in the StringCache maps. Old output strings remain reachable elsewhere in both base and candidate. An inspected strong retaining path runs through React props and onJumpToPreviousCheckpoint callback closure contexts into an old message array.

Cache cleanup is confirmed, but complete task-memory release is not. Investigating that existing callback retention remains a follow-up; these snapshots do not establish indefinite growth. Chat behavior and appearance are unchanged, and no forced remounts are introduced.

Validation and artifacts

Four focused webview suites: 108 tests pass; webview type checking and ESLint pass without increased suppressions.
Heap benchmark: 12 successful samples and 36 snapshots. One setup attempt using an earlier readiness check was excluded and successfully rerun.
Benchmark package type checking and ESLint pass.
The opt-in benchmark harness and results report are included in this PR under apps/vscode-e2e/src/heap/; raw snapshots, measurements and retaining-path evidence are gitignored under apps/vscode-e2e/heap-results/.

…y-optimization-0lkgswz0njjgl # Conflicts: # webview-ui/src/__tests__/App.spec.tsx # webview-ui/src/context/ExtensionStateContext.tsx # webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx

…njjgl

coderabbitai · 2026-10-28T03:28:47Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1

coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Zoo-Code-Org/Zoo-Code
Branch: main
File: .coderabbit.yaml
Commit: 3f51e9d
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 185d79ea-1dbe-4345-83b8-9a20ce70749c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

zoomote2 · 2026-10-28T03:28:52Z

No new code issues found. See session

Re-reviewed the new commit 2ff4aa6 ("Address webview memory optimization review feedback") on top of the previously reviewed 5ba6d60:

The messagesAreStale and internMessages extractions in ExtensionStateContext.tsx are behavior-preserving refactors of the inline logic verified last round, and the messageUpdated mirror now uses findLastIndex, aligning it with the React state update path (this fixes a first-vs-last duplicate-ts inconsistency in the mirror).
New tests cover initial/current-task history interning, keys dropped by JSON snapshots, duplicate-timestamp mirror updates, stale-task-push cache preservation, FIFO non-refresh on cache hits, and null/undefined interning; assertions match the implementation's actual semantics.
The heap harness changes (prepare.ts base variant now reverting only ExtensionStateContext.tsx, test.info() usage) are consistent with the updated README/RESULTS, which now clearly disclose that the recorded measurements are historical and not rerun for these fixes.
The earlier note about the PR description is resolved — the Validation section now correctly states the harness and results report are committed in this PR.

CI at this head: compile, codecov patch checks (including webview-patch), knip, translations, and VSIX build pass; remaining unit/visual/e2e jobs were still running at review time.

Previously reviewed at 5ba6d60 — string interning (stringCache.ts) and the cache lifecycle / task-identity guards in ExtensionStateContext.tsx, plus the tests and the opt-in heap benchmark under apps/vscode-e2e/src/heap/:

_{Reviewed 31e260a}

github-actions · 2026-10-28T03:29:01Z

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

codecov · 2026-10-28T04:00:33Z

Codecov Report

❌ Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
webview-ui/src/utils/stringCache.ts	97.29%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

…ites and retake the deleted cases Resolves the five open CodeRabbit threads on Zoo-Code-Org#1560 at 8cc8f33. Four are teardown in the specs this unit added; one is a behaviour change confined to the public API round trip. - extension/api.ts: setConfiguration drops viewStates from the settings payload before the forward write, and from the snapshot the rollback replays. The map is a snapshot of every view's selection: writing a caller's copy forward pins views this call does not own, and replaying the getter's copy on failure rolls them back to where this call found them. Both consult isNonPortableSettingsKey, the list the export schema above and the import path already use, which Zoo-Code-Org#2226 adds at its head (e9d0a2a) for the read side of the same round trip - that PR filters what an external caller may read, this one filters what it may write. getConfiguration and ContextProxy.getValues keep the key: the host's own consumers still need viewStates. - core/config/ContextProxy.ts: declares NON_PORTABLE_SETTINGS_KEYS and exports isNonPortableSettingsKey beside the export schema, so the two PRs share one rule instead of each keeping its own copy of the key list. - ClineProvider.spec: the mode-switch timeout test brackets its flow in try/finally so a failed assertion cannot leave the gate unresolved, the prototype spy installed, or the timers faked for the rest of the file. - webviewMessageHandler.spec: the sign-out suite restores the three fixture members its tests reassign. Measured control: with the assignments unrestored the file is still 176/176, so the leak is latent rather than failing - vi.clearAllMocks undoes call history, never a property assignment, and mockClineProvider.contextProxy alone is read 28 times by the eight describes that follow. - ClineProvider.sticky-mode.spec: the three temporary-id providers are disposed in finally, and the third restores mockContext.globalState.update there before disposing, so a failing assertion cannot leave the rejecting mock installed for the teardown below it. - webview-ui ExtensionStateContext.spec.tsx: restored the 13 cache-interning and task-identity cases main carries (from upstream c4ed96c, Zoo-Code-Org#2217) with the expectMessages, InternSpy and cacheFor scaffolding they need and main's afterEach(vi.restoreAllMocks). They came back with the merge of main; our scaffolding cleanup (fda1600) removed them without moving them anywhere, and webview-ui/src/utils/__tests__/stringCache.spec.ts covers the class, not this provider wiring. Verified: src tsc --noEmit exit 0; webview-ui tsc --noEmit exit 0; eslint --max-warnings=0 clean on every touched file with src/eslint-suppressions.json byte-for-byte unchanged; prettier clean. 856 tests green across api-configuration (17), api-set-configuration (1), ContextProxy (64), ClineProvider (448), sticky-mode (46), sticky-profile (23), apiHandlerRebuild (40), parallelMode (41) and webviewMessageHandler (176); webview-ui ExtensionStateContext 43/43. Test (negative control for the API filter): with neither filter in place the new case fails with `expected { Object (currentApiConfigName, modeApiConfigs, ...) } to not have property "viewStates"` while the other 16 cases in the file pass.

taltas and others added 6 commits August 31, 2026 18:55

perf(webview): reduce retained chat state

42c0eb1

Merge remote-tracking branch 'origin/main' into feature/webview-memor…

de8291c

…y-optimization-0lkgswz0njjgl # Conflicts: # webview-ui/src/__tests__/App.spec.tsx # webview-ui/src/context/ExtensionStateContext.tsx # webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx

fix(webview): bound string caches and guard task identity updates

b9a6ba0

test(webview): add real VS Code heap benchmark and results

d8832b2

test(webview): strengthen message state and completion coverage

134b684

Merge branch 'main' into feature/webview-memory-optimization-0lkgswz0…

5ba6d60

…njjgl

Address webview memory optimization review feedback

2ff4aa6

edelauna marked this pull request as ready for review October 28, 2026 03:56

edelauna requested review from JamesRobert20, edelauna and taltas as code owners October 28, 2026 03:56

github-actions Bot added the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Oct 28, 2026

fix(webview): keep task item with pinned task id

31e260a

github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer and removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Oct 28, 2026

p12tic approved these changes Oct 29, 2026

View reviewed changes

github-actions Bot added the community-approved Fresh community approval on the current head; maintainer review still required label Oct 29, 2026

edelauna approved these changes Oct 29, 2026

View reviewed changes

edelauna added this pull request to the merge queue Oct 29, 2026

github-actions Bot removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer community-approved Fresh community approval on the current head; maintainer review still required labels Oct 29, 2026

Merged via the queue into main with commit c4ed96c Oct 29, 2026
25 checks passed

edelauna deleted the feature/webview-memory-optimization-1466 branch October 29, 2026 21:46

Navigation Menu

Repository navigation

[Improve] Reduce chat memory retained during long sessions - #2217

[Improve] Reduce chat memory retained during long sessions#2217
edelauna merged 8 commits into
mainfrom
feature/webview-memory-optimization-1466

zoomote2 Bot commented Oct 28, 2026 •

edited by edelauna

Loading

Uh oh!

coderabbitai Bot commented Oct 28, 2026 •

edited

Loading

Review skipped

Uh oh!

zoomote2 Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zoomote2 Bot commented Oct 28, 2026 • edited by edelauna Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

Heap measurements

Task-switch finding

Validation and artifacts

Uh oh!

coderabbitai Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

zoomote2 Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review status

Uh oh!

codecov Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zoomote2 Bot commented Oct 28, 2026 •

edited by edelauna

Loading

coderabbitai Bot commented Oct 28, 2026 •

edited

Loading

zoomote2 Bot commented Oct 28, 2026 •

edited

Loading

github-actions Bot commented Oct 28, 2026 •

edited

Loading

codecov Bot commented Oct 28, 2026 •

edited

Loading