[Chore] Speed up lint and check-types with caches and staged-only pre-commit lint - #2092

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Closes: #2090

Description

This PR makes local lint and type checks faster. It implements the proposal in #2090.

Changes:

• The lint scripts in src and webview-ui now pass --cache --cache-strategy content to ESLint. The cache lives at node_modules/.cache/eslint/.eslintcache in each package. That path is already git-ignored, so .gitignore needs no change.
• src/tsconfig.json and webview-ui/tsconfig.json now set "incremental": true with a tsBuildInfoFile under node_modules/.cache/tsc/. The shared default in packages/config-typescript/base.json is unchanged. declaration stays off, as measured in the issue.
• The pre-commit hook no longer runs pnpm lint on the whole repository. It runs lint-staged only. The lint-staged config now routes staged .ts/.tsx files to the ESLint config of their own package, so staged files in every workspace package keep full lint coverage. Prettier still formats staged files.
• CI keeps the full lint. The compile job in .github/workflows/code-qa.yml already runs pnpm lint and pnpm check-types, so no workflow change is needed.
• The check-types script in webview-ui is now tsc --noEmit. It was plain tsc, but the tsconfig already set "noEmit": true, so it never emitted. The emit output of webview-ui comes from the build script (tsc -b && vite build); vite owns the emitted files. No consumer reads output from check-types.

Trade-off from the issue: without declaration, incremental checks pay off in full only for leaf-file edits. Edits to shared files still recheck dependents.

Test Procedure

Measured in the task sandbox (18 cores, warm turbo cache bypassed with --force, so the numbers show real ESLint and tsc work):

Repeat steps for reviewers:

1. Run pnpm lint twice. The second run skips unchanged files through the ESLint cache.
2. Run pnpm check-types twice. The second run uses the incremental build info.
3. Stage one changed source file and commit. The hook lints only staged files.
4. Add const x: any = null to a staged file in src and commit. ESLint blocks the commit with @typescript-eslint/no-explicit-any.

Also verified:

• pnpm lint and pnpm check-types pass at the repo root (11/11 turbo tasks).
• pnpm test passes (13/13 turbo tasks, ~11000 tests). One first run had 2 failures in src/__tests__/extension.spec.ts under full parallel load. The spec passes in isolation on a clean tree and on this tree, and the full suite passed on rerun. This is a pre-existing load flake, not a change from this PR.
• pnpm format:check passes.
• Cache files land only in git-ignored paths. git status stays clean.
• tsc -b in webview-ui stays correct and fast with the shared tsBuildInfoFile (up-to-date build in 0.27s after a warm check-types).

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I reviewed my own code with care.
• Writing Style: The PR title and description use Simplified Technical English (ASD-STE100): short sentences, plain words, active voice, one idea per sentence, no contractions.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Visual Snapshot (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I added or updated a *.visual.tsx snapshot in webview-ui/. See webview-ui/AGENTS.md → "When a UI change needs a snapshot".
• Documentation Impact: I checked if my changes need documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I read and agree to the Contributor Guidelines.

Visual Snapshots

This PR changes build tooling only. It has no user-visible UI surface.

Videos (interaction / animation only)

No interaction or animation changes. No video needed.

Documentation Updates

• No documentation updates are required.

This PR changes developer tooling. User-facing product behavior does not change.

Additional Notes

• The lint-staged config lists one entry per workspace package. This keeps staged-file lint coverage equal to the old full pnpm lint for .ts/.tsx files, including packages outside src and webview-ui.
• The ESLint cache and tsbuildinfo files live under node_modules/.cache/. Deleting them is always safe. The next run rebuilds them.
• webview-ui's clean script now also removes node_modules/.cache/tsc, because the build info moved there.
• Timings come from an 18-core sandbox. They differ in scale from the issue's WSL2 20-core numbers but show the same ratios.

Get in Touch

0x7777777_