Skip to content

chore(deps): align @vitest/coverage-v8 and @vitest/ui to the vitest 4.1.11 peer line - #2037

Closed
easonLiangWorldedtech wants to merge 3 commits into
Zoo-Code-Org:mainfrom
easonLiangWorldedtech:chore/vitest-4.1.11
Closed

easonLiangWorldedtech wants to merge 3 commits into
Zoo-Code-Org:mainfrom
easonLiangWorldedtech:chore/vitest-4.1.11

Conversation

@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor

What

Align @vitest/coverage-v8 (and webview-ui's @vitest/ui) to the workspace's vitest 4.1.11 peer line:

  • apps/cli, packages/cloud, packages/core, packages/telemetry, src, webview-ui: @vitest/coverage-v8 4.1.9 → 4.1.11
  • webview-ui: @vitest/ui 4.1.9 → 4.1.11
  • pnpm-lock.yaml regenerated with pnpm install --lockfile-only

Why

The workspace already pins vitest 4.1.11 in several packages while the coverage/UI packages stayed on 4.1.9; coverage runners resolve the 4.1.9 peers against the 4.1.11 runtime. This was originally carried inside the abort-signal native-ollama unit (PR 1299) and moved here at reviewer request so that unit carries no dependency churn.

Verification

  • pnpm install --lockfile-only regenerates cleanly (lock diff is vitest-entry churn only)
  • No source changes; CI is the gate

….1.11 peer line

The workspace pins vitest 4.1.11 in several packages while
@vitest/coverage-v8 (and webview-ui's @vitest/ui) stayed on 4.1.9.
Coverage runners resolve the 4.1.9 peers against the 4.1.11 runtime;
align the coverage/UI packages to the same 4.1.11 line across
apps/cli, packages/cloud, packages/core, packages/telemetry, src, and
webview-ui, with the lockfile regenerated.

Extracted from the abort-signal native-ollama unit (PR 1299) at
reviewer request so that unit carries no dependency churn.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Zoo-Code-Org/Zoo-Code/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 85408d5f-2a3c-4121-8b16-29d410f4198c
📥 Commits

Reviewing files that changed from the base of the PR and between bb6dc20 and 2c4e71e.

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 3
  • apps/cli/package.json
  • src/package.json
  • webview-ui/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review.

📜 Recent review details
🧰 Additional context used
📓 Path-based instructions: 3
Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark theme behavior.

⚙️ CodeRabbit configuration file

Files:

  • webview-ui/package.json
Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.

⚙️ CodeRabbit configuration file

Files:

  • src/package.json
Act as an adversarial second-opinion reviewer.

⚙️ CodeRabbit configuration file

Files:

  • src/package.json
  • webview-ui/package.json
  • apps/cli/package.json
🔇 Additional comments: 3
apps/cli/package.json: 1

42-42: LGTM!

src/package.json: 1

557-557: LGTM!

webview-ui/package.json: 1

103-104: LGTM!

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated test coverage tooling across the project to version 4.1.11. This maintenance update does not change user-facing features or behavior.

The @vitest/coverage-v8 development dependency is updated from 4.1.9 to 4.1.11 in five package manifests. The webview-ui manifest also updates @vitest/ui from 4.1.9 to 4.1.11.

Changes: Vitest dependency updates

Layer / File(s) Summary
Development dependency version updates
apps/cli/package.json, packages/cloud/package.json, packages/core/package.json, packages/telemetry/package.json, src/package.json, webview-ui/package.json
Five manifests update @vitest/coverage-v8 from 4.1.9 to 4.1.11. The webview-ui manifest also updates @vitest/ui from 4.1.9 to 4.1.11.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2c4e7

The dependency updates and lockfile are aligned at 4.1.11. No concrete merge-blocking behavior change is evident; the PR is ready for normal checks.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

Failed Failed checks: 1 error · 1 warning

Check name Status Explanation Resolution
Linked Issues check Error The description does not link this pull request to an approved GitHub Issue. Add an approved GitHub Issue reference in the required format, such as "Closes: #123".
Description check Warning The description explains the dependency updates, reason, and verification steps. It does not follow the repository template because it omits the required linked issue, checklist, test procedure sectio… Add the required template sections. Link an approved GitHub Issue, describe the test procedure and repeatable commands, complete the pre-submission checklist, address visual snapshots and documentation impact, and provide any required addit…
Passed Passed checks: 6 passed
Check name Status Explanation
Regression Evidence Passed PASS. The pull request changes only Vitest development dependency versions in six package manifests and the corresponding lockfile entries. It introduces no source behavior, error branch, negative bra…
Security Boundaries Passed The pull request changes only Vitest dependency declarations in six package manifests and matching pnpm lockfile entries. The diff adds no source, command, authentication, data-handling, input-validat…
Persistence Integrity Passed PASS. The reviewed range changes only six package manifests and pnpm-lock.yaml. The changes update Vitest dependency versions and lockfile resolutions; they do not add or modify a persistence path, wr…
Lifecycle Resource Cleanup Passed PASS. The pull request changes only package manifests and pnpm-lock.yaml. The diff contains dependency version and lockfile updates, with no changed lifecycle code or paths that create, cancel, dispos…
Out of Scope Changes check Passed The changes are limited to aligning Vitest coverage and UI dependency versions and regenerating the lockfile.
Title check Passed The title clearly identifies the dependency alignment and specifies the affected Vitest versions. It matches the main change.
Full details: Regression Evidence

Explanation

PASS. The pull request changes only Vitest development dependency versions in six package manifests and the corresponding lockfile entries. It introduces no source behavior, error branch, negative branch, or visible UI change. The custom check explicitly does not require tests for mechanical configuration changes, and no Playwright snapshot is required.

Full details: Security Boundaries

Explanation

The pull request changes only Vitest dependency declarations in six package manifests and matching pnpm lockfile entries. The diff adds no source, command, authentication, data-handling, input-validation, approval, or allowlist logic. No changed path meets the stated security failure conditions.

Full details: Persistence Integrity

Explanation

PASS. The reviewed range changes only six package manifests and pnpm-lock.yaml. The changes update Vitest dependency versions and lockfile resolutions; they do not add or modify a persistence path, write operation, rollback behavior, or persisted default. Therefore, the stated persistence-integrity failure condition is not introduced.

Full details: Lifecycle Resource Cleanup

Explanation

PASS. The pull request changes only package manifests and pnpm-lock.yaml. The diff contains dependency version and lockfile updates, with no changed lifecycle code or paths that create, cancel, dispose, restart, or duplicate resource work. Therefore, no concrete lifecycle resource leak or cancellation duplication is introduced.

Full details: Description check

Explanation

The description explains the dependency updates, reason, and verification steps. It does not follow the repository template because it omits the required linked issue, checklist, test procedure section, documentation impact, and other required sections.

Resolution

Add the required template sections. Link an approved GitHub Issue, describe the test procedure and repeatable commands, complete the pre-submission checklist, address visual snapshots and documentation impact, and provide any required additional notes and contact details.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review status

Thanks for contributing. This comment tracks the review sequence and the next action.

Current step: Resolve the merge conflicts. The review sequence resumes after the branch is mergeable.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@github-actions github-actions Bot added coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit labels Oct 13, 2026
@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 13, 2026
@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer and removed coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit labels Oct 13, 2026
@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer and removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Oct 14, 2026
# Conflicts:
#	apps/cli/package.json
#	pnpm-lock.yaml
@github-actions github-actions Bot added coderabbit-review-active Required CI passed; CodeRabbit review is active awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit and removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Oct 18, 2026
@github-actions github-actions Bot removed the coderabbit-review-active Required CI passed; CodeRabbit review is active label Oct 18, 2026
@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer has-conflicts PR has merge conflicts with the base branch awaiting-author PR is waiting for the author to address requested changes and removed awaiting-coderabbit Waiting for CodeRabbit to approve the latest commit awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Oct 18, 2026
@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor Author

Closing as superseded by main ??the version alignment this PR exists to perform is already there.

The PR's own change (merge-base e4e112e15..2c4e71e68) is exactly the 4.1.9 ??4.1.11 bump:

 apps/cli/package.json           | 2 +-
 packages/cloud/package.json     | 2 +-
 packages/core/package.json      | 2 +-
 packages/telemetry/package.json | 2 +-
 src/package.json                | 2 +-
 webview-ui/package.json         | 4 ++--
 6 files changed, 7 insertions(+), 7 deletions(-)

Current upstream/main already pins the target versions:

apps/cli/package.json:42:        @vitest/coverage-v8: 4.1.11
packages/cloud/package.json:25:  @vitest/coverage-v8: 4.1.11
packages/core/package.json:34:   @vitest/coverage-v8: 4.1.11
packages/telemetry/package.json:24: @vitest/coverage-v8: 4.1.11
src/package.json:557:           @vitest/coverage-v8: 4.1.11
webview-ui/package.json:103:    @vitest/coverage-v8: 4.1.11
webview-ui/package.json:104:    @vitest/ui: 4.1.11

Merging it now would be an empty diff against main. Reopen if a future round needs a different alignment target ??the branch is left untouched (2c4e71e68).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author PR is waiting for the author to address requested changes has-conflicts PR has merge conflicts with the base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants